Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iap base path as tunnel is generated #3162

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

slevenick
Copy link
Contributor

Should not cause downstream issues. This is causing problems for #3135 in the beta provider

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 16 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 17 deletions(-))

@slevenick slevenick mentioned this pull request Feb 24, 2020
@slevenick slevenick requested a review from emilymye February 24, 2020 22:06
Copy link
Contributor

@emilymye emilymye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks for catching this!

@slevenick slevenick merged commit abc8dc9 into GoogleCloudPlatform:master Feb 26, 2020
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
* Remove iap base path as tunnel is generated

* Remove more iap specific config that we dont need

* Another reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants