Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for bucket retention policy list being empty. #3181

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Added check for bucket retention policy list being empty. #3181

merged 2 commits into from
Feb 28, 2020

Conversation

xingao267
Copy link
Member

@xingao267 xingao267 commented Feb 27, 2020 •
edited
Loading

Release Note Template for Downstream PRs (will be copied)

storage: Added check for bucket retention policy list being empty.

@xingao267 xingao267 changed the title Empty bucket rentention policy list should be checked. Added check for bucket retention policy list being empty. Feb 27, 2020
@xingao267 xingao267 mentioned this pull request Feb 27, 2020
Merged
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 16 insertions(+), 9 deletions(-))

@xingao267
Copy link
Member Author

@danawillow @chrisst ptal

@danawillow danawillow self-requested a review February 27, 2020 22:32
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 11 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 1 file changed, 11 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 15 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 10 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 1 file changed, 10 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 15 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 10 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 1 file changed, 10 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 15 insertions(+), 9 deletions(-))

@danawillow danawillow merged commit 768b39c into GoogleCloudPlatform:master Feb 28, 2020
@xingao267 xingao267 deleted the bucket branch February 28, 2020 17:44
This was referenced Feb 28, 2020
Merged
Merged
Merged
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@xingao267
Added check for bucket retention policy list being empty. (GoogleClou…
fd8c534 
…dPlatform#3181)

* Empty bucket rentention policy list should be checked.

* Address code review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xingao267 @modular-magician @danawillow @googlebot