-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sql_source_representation_instance #3186
add sql_source_representation_instance #3186
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 6 files changed, 703 insertions(+), 2 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 6 files changed, 707 insertions(+), 2 deletions(-)) |
Looks good (at least within the bounds of being Cloud-SQL-y). I assume there isn't an actual instance being created, so it's fine to have default timeouts be only 4 minutes? |
Yeah it creates nearly instantly so 4 minutes is plenty, good catch though! |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 6 files changed, 707 insertions(+), 2 deletions(-)) |
* add sql_source_representation_instance * exclude ansible/inspec * requireds, defaults, validations * typo
Fixes hashicorp/terraform-provider-google#3704
Release Note Template for Downstream PRs (will be copied)