Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sql_source_representation_instance #3186

Merged

Conversation

danawillow
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#3704

Release Note Template for Downstream PRs (will be copied)

`google_sql_source_representation_instance`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 703 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 703 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 118 insertions(+))
TF OiCS: Diff ( 4 files changed, 108 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 707 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 707 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 118 insertions(+))
TF OiCS: Diff ( 4 files changed, 108 insertions(+))

@danawillow danawillow requested a review from emilymye February 28, 2020 21:34
@emilymye
Copy link
Contributor

Looks good (at least within the bounds of being Cloud-SQL-y). I assume there isn't an actual instance being created, so it's fine to have default timeouts be only 4 minutes?

@danawillow
Copy link
Contributor Author

Yeah it creates nearly instantly so 4 minutes is plenty, good catch though!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 707 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 707 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 118 insertions(+))
TF OiCS: Diff ( 4 files changed, 108 insertions(+))

@danawillow danawillow requested a review from emilymye March 5, 2020 17:28
@danawillow danawillow merged commit 2083312 into GoogleCloudPlatform:master Mar 5, 2020
@danawillow danawillow deleted the is-3704-sql-external-replica branch March 5, 2020 20:33
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
* add sql_source_representation_instance

* exclude ansible/inspec

* requireds, defaults, validations

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudSQL - Replicating from an external server
4 participants