Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields to instance template's network_interfaces schema #3197

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

rileykarson
Copy link
Member

Fix for b/150632967

The name field getting returned hasn't happened in prod, but this should make us more resilient when it happens. Also reorder the schemas to have the same ordering.

I tried to test this, but it didn't appear in beta staging. I'm confident that adding new fields to the schema is safe to do.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 20 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 2 files changed, 20 insertions(+), 10 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants