-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a resource for fine-grained management of named ports #3236
Add a resource for fine-grained management of named ports #3236
Conversation
} | ||
return v | ||
|
||
// number values are represented as float64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patchencoder for the fine-grained resource deep-compared the returned value, including the type. Terraform stores TypeInt
as int
, so we need to return that to compare properly. Before, we passed the value onto TF core where it did the conversion.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 59 files changed, 2086 insertions(+), 300 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 60 files changed, 2165 insertions(+), 300 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to have the validator resource?
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 61 files changed, 2339 insertions(+), 330 deletions(-)) |
a2939c5
to
c2798f6
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 62 files changed, 2348 insertions(+), 332 deletions(-)) |
…dPlatform#3236) * Add a resource for fine-grained management of named ports in instance groups * Add excludes * second ansible exclude * Add back delete * Fix schema, docs * Add mutex, pull extra values from group
Fixes hashicorp/terraform-provider-google#1480
Release Note Template for Downstream PRs (will be copied)