Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a resource for fine-grained management of named ports #3236

Merged
merged 6 commits into from
Mar 19, 2020

Conversation

rileykarson
Copy link
Member

Fixes hashicorp/terraform-provider-google#1480

Release Note Template for Downstream PRs (will be copied)

`google_compute_instance_group_named_port`

}
return v

// number values are represented as float64
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patchencoder for the fine-grained resource deep-compared the returned value, including the type. Terraform stores TypeInt as int, so we need to return that to compare properly. Before, we passed the value onto TF core where it did the conversion.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 59 files changed, 2086 insertions(+), 300 deletions(-))
Terraform Beta: Diff ( 70 files changed, 2788 insertions(+), 456 deletions(-))
TF Conversion: Diff ( 1 file changed, 69 insertions(+))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 60 files changed, 2165 insertions(+), 300 deletions(-))
Terraform Beta: Diff ( 71 files changed, 2867 insertions(+), 456 deletions(-))
TF Conversion: Diff ( 1 file changed, 69 insertions(+))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

Copy link
Contributor

@emilymye emilymye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to have the validator resource?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 61 files changed, 2339 insertions(+), 330 deletions(-))
Terraform Beta: Diff ( 72 files changed, 3059 insertions(+), 490 deletions(-))
TF Conversion: Diff ( 1 file changed, 78 insertions(+))
TF OiCS: Diff ( 4 files changed, 142 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 62 files changed, 2348 insertions(+), 332 deletions(-))
Terraform Beta: Diff ( 72 files changed, 3059 insertions(+), 490 deletions(-))
TF Conversion: Diff ( 1 file changed, 78 insertions(+))
TF OiCS: Diff ( 4 files changed, 142 insertions(+))

@rileykarson rileykarson merged commit 52c9c32 into GoogleCloudPlatform:master Mar 19, 2020
@rileykarson rileykarson deleted the backend-ports branch March 19, 2020 15:03
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
…dPlatform#3236)

* Add a resource for fine-grained management of named ports in instance groups

* Add excludes

* second ansible exclude

* Add back delete

* Fix schema, docs

* Add mutex, pull extra values from group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google backend_service to container_node_pool and named ports
4 participants