Serial port datasource #3247
Serial port datasource #3247
Conversation
There was a problem hiding this comment.
My biggest concern here is the unbounded nature of this polling loop. It doesn't timeout or fail if the API continues to respond with a non empty response. Is it possible to calculate a max number of queries that will be required before which it should fail? Or can this have a configurable read timeout added? Since this will be queried on every refresh it makes me a bit nervous.
| contents := output.Contents | ||
| // When we reach the end of the serial port output stream the contents comes back empty | ||
| for output.Contents != "" { | ||
| output, err = config.clientCompute.Instances.GetSerialPortOutput(project, zone, d.Get("instance").(string)).Port(port).Start(output.Next).Do() |
There was a problem hiding this comment.
Might be worth adding a debug log line here. It could be helpful understanding if this happens infinitely or takes longer than expected.
There was a problem hiding this comment.
My biggest concern here is the unbounded nature of this polling loop. It doesn't timeout or fail if the API continues to respond with a non empty response. Is it possible to calculate a max number of queries that will be required before which it should fail? Or can this have a configurable read timeout added? Since this will be queried on every refresh it makes me a bit nervous.
There was a problem hiding this comment.
My biggest concern here is the unbounded nature of this polling loop. It doesn't timeout or fail if the API continues to respond with a non empty response. Is it possible to calculate a max number of queries that will be required before which it should fail? Or can this have a configurable read timeout added? Since this will be queried on every refresh it makes me a bit nervous.
Good point. I removed the polling loop because I don't think its feasible to have a serial port output that won't fit in one request (output is limited to the last 1MB by the API). If we run into issues in the future where someone wants this we can add back, but I don't expect that. |
* Add serial port datasource * Add doc for serial port ds * Serial port test * Formatting * Markdown fixes * Remove pagination, we should always be able to retrieve 1MB
Fixes: hashicorp/terraform-provider-google#1578
Fixes: hashicorp/terraform-provider-google#1472
The ability to read serial port output enables windows password generation.
Release Note Template for Downstream PRs (will be copied)