-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry for google_kms_crypto_key_version
#3255
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 20 insertions(+), 1 deletion(-)) |
5416529
to
8de92be
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 20 insertions(+), 1 deletion(-)) |
@@ -105,7 +105,16 @@ func dataSourceGoogleKmsCryptoKeyVersionRead(d *schema.ResourceData, meta interf | |||
return err | |||
} | |||
log.Printf("[DEBUG] Getting public key of CryptoKeyVersion: %#v", url) | |||
res, _ = sendRequest(config, "GET", cryptoKeyId.KeyRingId.Project, url, nil) | |||
|
|||
err = retryTimeDuration(func() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should be able to specify the error retry pred and timeout using sendRequestWithTimeout
instead, and you won't need this retryTimeDuration
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 17 insertions(+), 1 deletion(-)) |
google_kms_crypto_key_version
google_kms_crypto_key_version
* Add retryTimeDuration for crypto key versions * Change to sendRequestWithTimeout
Fixes hashicorp/terraform-provider-google#5895
Release Note Template for Downstream PRs (will be copied)