Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible - Resource Policy #3275

Merged
merged 5 commits into from
Mar 20, 2020
Merged

Ansible - Resource Policy #3275

merged 5 commits into from
Mar 20, 2020

Conversation

rambleraptor
Copy link
Contributor

@rambleraptor rambleraptor commented Mar 19, 2020

Ansible Resource Policy

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 1 insertion(+), 19 deletions(-))
Terraform Beta: Diff ( 2 files changed, 1 insertion(+), 19 deletions(-))
Ansible: Diff ( 8 files changed, 1187 insertions(+))

@rambleraptor
Copy link
Contributor Author

GCP API says that this Compute Resource is not async (Ansible tests confirm this).

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Ansible: Diff ( 8 files changed, 1223 insertions(+))

@rambleraptor rambleraptor requested a review from danawillow March 20, 2020 00:05
@rambleraptor
Copy link
Contributor Author

@danawillow please take a look!

Resource Policies list endpoint uses the 'items' key (docs)

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Terraform

@rambleraptor rambleraptor merged commit bf31f33 into master Mar 20, 2020
@rambleraptor rambleraptor deleted the policies branch March 20, 2020 00:13
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
* resource policy

* fixed

* rebase issues

* finally fixed

* async fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants