Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use scheduling from template rather than instance defaults #3352

Merged
merged 1 commit into from
Apr 7, 2020
Merged

use scheduling from template rather than instance defaults #3352

merged 1 commit into from
Apr 7, 2020

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Apr 7, 2020

Use scheduling from template rather than instance defaults
Fixes hashicorp/terraform-provider-google#6050

Release Note Template for Downstream PRs (will be copied)

compute: fixed bug where `google_compute_instance_from_template` instance defaults were overriding `scheduling`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 80 insertions(+))
Terraform Beta: Diff ( 2 files changed, 80 insertions(+))

@megan07 megan07 requested a review from chrisst April 7, 2020 16:13
@megan07 megan07 merged commit 9835015 into GoogleCloudPlatform:master Apr 7, 2020
This was referenced Apr 7, 2020
Merged
Merged
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@megan07
use scheduling from template rather than defaults (GoogleCloudPlatfor…
ef0371e 
…m#3352)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisst chrisst chrisst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_compute_instance_from_template doesn't get scheduling parameters from template
4 participants
@megan07 @modular-magician @chrisst @googlebot