Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Directory Cloud DNS integration #3398

Merged
merged 2 commits into from
Apr 22, 2020

Conversation

drebes
Copy link
Member

@drebes drebes commented Apr 21, 2020

Release Note Template for Downstream PRs (will be copied)

dns: Added `service_directory_config` field to`google_dns_managed_zone` (Beta only)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 39 insertions(+))
Terraform Beta: Diff ( 3 files changed, 241 insertions(+))
TF OiCS: Diff ( 4 files changed, 130 insertions(+))
Inspec: Diff ( 6 files changed, 82 insertions(+))

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change, otherwise looks good!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 39 insertions(+))
Terraform Beta: Diff ( 3 files changed, 241 insertions(+))
TF OiCS: Diff ( 4 files changed, 130 insertions(+))
Inspec: Diff ( 6 files changed, 82 insertions(+))

@slevenick slevenick self-requested a review April 22, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants