Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deletion_protection field for bigtable instance #3450

Merged
merged 3 commits into from
May 12, 2020

Conversation

danawillow
Copy link
Contributor

@danawillow danawillow commented Apr 30, 2020

I called it allow_destroy to align with prevent_destroy and terraform destroy, but feel free to suggest a different name if you'd like.

I'm not considering this a breaking change because it doesn't affect users until they want to make a change, but let me know if you disagree.

Once this is merged, I'll follow up with the other bigtable resources.

EDIT: it's called deletion_protection now to align with the field in compute instance.

Release Note Template for Downstream PRs (will be copied)

* bigtable: added `deletion_protection` field to `google_bigtable_instance` to make deleting them require an explicit intent.
* `google_bigtable_instance` resources now cannot be destroyed unless `deletion_protection = false` is set in state for the resource.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 104 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 9 files changed, 104 insertions(+), 11 deletions(-))
TF OiCS: Diff ( 2 files changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 104 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 9 files changed, 104 insertions(+), 11 deletions(-))
TF OiCS: Diff ( 2 files changed, 4 insertions(+))

@danawillow
Copy link
Contributor Author

+riley for oics stuff

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OiCS changes lgtm- leaving clicking the approval button to @megan07

@danawillow danawillow changed the title add allow_destroy field for bigtable instance add deletion_protection field for bigtable instance May 12, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 196 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 10 files changed, 196 insertions(+), 13 deletions(-))
TF OiCS: Diff ( 2 files changed, 4 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 196 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 10 files changed, 196 insertions(+), 13 deletions(-))
TF OiCS: Diff ( 2 files changed, 4 insertions(+))

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 196 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 10 files changed, 196 insertions(+), 13 deletions(-))
TF OiCS: Diff ( 2 files changed, 4 insertions(+))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants