Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for advertise_mode on compute_router_peer #3454

Merged
merged 1 commit into from
May 1, 2020
Merged

Add default value for advertise_mode on compute_router_peer #3454

merged 1 commit into from
May 1, 2020

Conversation

sebglon
Copy link
Contributor

@sebglon sebglon commented May 1, 2020

Release Note Template for Downstream PRs (will be copied)

compute: fixed issue where the default value for the attribute `advertise_mode` on `google_compte_router_peer` was not populated on import

Fixes hashicorp/terraform-provider-google#6259

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rambleraptor, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+))

@rambleraptor rambleraptor requested review from danawillow and removed request for rambleraptor May 1, 2020 17:01
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sebglon!

FYI I updated your PR description to make the changelog note a bit more clear and also to auto-close the bug that this fixes- take a look if you're curious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_router_peer import not populate the advertise_mode
4 participants