-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kalm (K8s Application lifecycle manager) addon config added #3459
kalm (K8s Application lifecycle manager) addon config added #3459
Conversation
Oops! It looks like you're using an unknown release-note type in your changelog entries: Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I made some changes to your PR description- take a look at what it looks like now for an idea of how we typically would format the description and the changelog (especially use of the 'fixes' keyword in order to auto-close the linked issue).
I also added a small nit to the test. Once that's changed, this will be good to merge.
third_party/terraform/tests/resource_container_cluster_test.go.erb
Outdated
Show resolved
Hide resolved
…oudPlatform#3459) * kalm addon config added * kalm addon tests added * Update resource_container_cluster_test.go.erb * PR comments fixed
Application Manager addon (KALM) config added to provider.
Fixes hashicorp/terraform-provider-google#5960
Release Note Template for Downstream PRs (will be copied)