Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kalm (K8s Application lifecycle manager) addon config added #3459

Conversation

venkykuberan
Copy link
Contributor

@venkykuberan venkykuberan commented May 1, 2020

Application Manager addon (KALM) config added to provider.
Fixes hashicorp/terraform-provider-google#5960

Release Note Template for Downstream PRs (will be copied)

* container: added `kalm_config` addon to `google_container_cluster` (beta-only)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 3 insertions(+))
Terraform Beta: Diff ( 3 files changed, 43 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:
*

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made some changes to your PR description- take a look at what it looks like now for an idea of how we typically would format the description and the changelog (especially use of the 'fixes' keyword in order to auto-close the linked issue).

I also added a small nit to the test. Once that's changed, this will be good to merge.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 3 insertions(+))
Terraform Beta: Diff ( 3 files changed, 43 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 3 insertions(+))
Terraform Beta: Diff ( 3 files changed, 42 insertions(+), 1 deletion(-))

@venkykuberan venkykuberan merged commit 3b86411 into GoogleCloudPlatform:master May 2, 2020
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
…oudPlatform#3459)

* kalm addon config added

* kalm addon tests added

* Update resource_container_cluster_test.go.erb

* PR comments fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for beta ApplicationManager GKE add-on
4 participants