Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configConnector GKE addon config added to cluster resource #3498

Conversation

venkykuberan
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

fixes - https://github.com/terraform-providers/terraform-provider-google/issues/6300

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 22 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 65 insertions(+), 9 deletions(-))

@@ -134,28 +134,29 @@ func TestAccContainerCluster_withAddons(t *testing.T) {
t.Parallel()

clusterName := fmt.Sprintf("tf-test-cluster-%s", randString(t, 10))
pid := getTestProjectFromEnv()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use "project", unless this is in use elsewhere in the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pid was used in other tests, just used the same to be consistent

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could let me know how you've tested this I'll merge! :)

@venkykuberan
Copy link
Contributor Author

If you could let me know how you've tested this I'll merge! :)
ran the acceptance tests with
1) initialize the resource with addon configConenctor - false
2) update the resource with addon configConenctor - true

Tests passed which i believe it confirms the property is settable on the resource and resource is importable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants