-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configConnector GKE addon config added to cluster resource #3498
configConnector GKE addon config added to cluster resource #3498
Conversation
@@ -134,28 +134,29 @@ func TestAccContainerCluster_withAddons(t *testing.T) { | |||
t.Parallel() | |||
|
|||
clusterName := fmt.Sprintf("tf-test-cluster-%s", randString(t, 10)) | |||
pid := getTestProjectFromEnv() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use "project", unless this is in use elsewhere in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pid was used in other tests, just used the same to be consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could let me know how you've tested this I'll merge! :)
Tests passed which i believe it confirms the property is settable on the resource and resource is importable |
Release Note Template for Downstream PRs (will be copied)