Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credentials to bigquery connection. #3546

Merged
merged 13 commits into from
May 27, 2020

Conversation

nat-henderson
Copy link
Contributor

@nat-henderson nat-henderson commented May 20, 2020

Release Note Template for Downstream PRs (will be copied)

bigquery: Add ability to manage credentials to `google_bigquery_connection`.  This field is required as the resource is not useful without them.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 3 files changed, 133 insertions(+))
TF OiCS: Diff ( 1 file changed, 16 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 3 files changed, 133 insertions(+))
TF OiCS: Diff ( 1 file changed, 16 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 3 files changed, 165 insertions(+))
TF OiCS: Diff ( 2 files changed, 32 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 4 files changed, 197 insertions(+))
TF OiCS: Diff ( 2 files changed, 32 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 4 files changed, 197 insertions(+))
TF OiCS: Diff ( 2 files changed, 32 insertions(+))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this connected to any issues?

Could the cloud_sql part of the resource ever worked without credentials? It's a little spooky to add a required field to an existing resource.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 4 files changed, 172 insertions(+), 32 deletions(-))
TF OiCS: Diff ( 2 files changed, 32 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 4 files changed, 197 insertions(+))
TF OiCS: Diff ( 2 files changed, 32 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 4 files changed, 197 insertions(+))
TF OiCS: Diff ( 2 files changed, 32 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 4 files changed, 197 insertions(+))
TF OiCS: Diff ( 2 files changed, 32 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 4 files changed, 197 insertions(+))
TF OiCS: Diff ( 2 files changed, 32 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 4 files changed, 187 insertions(+))
TF OiCS: Diff ( 2 files changed, 32 insertions(+))

@nat-henderson
Copy link
Contributor Author

There we go - tests pass!

@hcliff
Copy link
Contributor

hcliff commented Jun 5, 2020

@ndmckinley thanks for this!

@rileykarson credential was only added when bigquery connection moved into GA, prior to that the property simply wasn't settable via the api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants