Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable google_dns_managed_zone to accept network id for two attributes #3602

Merged
merged 4 commits into from
Jun 4, 2020

Conversation

edwardmedia
Copy link
Contributor

@edwardmedia edwardmedia commented Jun 3, 2020

fixes hashicorp/terraform-provider-google#6498

Release Note Template for Downstream PRs (will be copied)

enable google_dns_managed_zone to accept network id for two attributes

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 40 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 3 files changed, 39 insertions(+), 20 deletions(-))
Ansible: Diff ( 2 files changed, 20 insertions(+), 12 deletions(-))
TF Conversion: Diff ( 1 file changed, 21 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))
Inspec: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

@danawillow
Copy link
Contributor

Because the descriptions changed, this updated the descriptions in ansible/inspec which don't actually support the new format. Can you override the description in terraform.yaml so that the new format only shows up in those docs instead of in all the generated ones?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 40 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 3 files changed, 39 insertions(+), 20 deletions(-))
TF Conversion: Diff ( 1 file changed, 21 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@danawillow
Copy link
Contributor

Oh, this has release-note:none but it should be an enhancement because it adds new functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable google_dns_managed_zone to accept network id for two attributes
4 participants