-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bigquery dataset iam #3608
Bigquery dataset iam #3608
Conversation
8ef3717
to
f78dd96
Compare
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118254" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118257" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118276" |
}, | ||
} | ||
|
||
var bigqueryAccessPrimitiveToRoleMap = map[string]string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting - maybe we should move the opposite RoleToPrimativeMap here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The opposite map has the DSF that uses it alongside it, so I'd prefer to keep that together
third_party/terraform/website/docs/r/bigquery_dataset_iam.html.markdown
Outdated
Show resolved
Hide resolved
|
||
* `dataset_id` - (Required) The dataset ID, in the form `projects/{project}/datasets/{dataset_id}` | ||
|
||
* `member/members` - (Required) Identities that will be granted the privilege in `role`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- bigquery special members?
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118792" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118794" |
Fixes: hashicorp/terraform-provider-google#5520
This converts bigquery dataset
access
field to an IAM policy, and IAM policy toaccess
to fit the bigquery dataset permission to our existing IAM model. These resources will always overwrite any authorized views on a dataset when they are applied as authorized views are a dataset specific construct and do not fit into the existing IAM model.Release Note Template for Downstream PRs (will be copied)