Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigquery dataset iam #3608

Merged
merged 10 commits into from
Jun 8, 2020

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Jun 5, 2020

Fixes: hashicorp/terraform-provider-google#5520

This converts bigquery dataset access field to an IAM policy, and IAM policy to access to fit the bigquery dataset permission to our existing IAM model. These resources will always overwrite any authorized views on a dataset when they are applied as authorized views are a dataset specific construct and do not fit into the existing IAM model.

Release Note Template for Downstream PRs (will be copied)

`google_bigquery_dataset_iam_binding`
`google_bigquery_dataset_iam_member`
`google_bigquery_dataset_iam_policy`

@slevenick slevenick force-pushed the bigquery-dataset-iam branch from 8ef3717 to f78dd96 Compare June 5, 2020 18:30
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 621 insertions(+))
Terraform Beta: Diff ( 6 files changed, 621 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118254"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 621 insertions(+))
Terraform Beta: Diff ( 6 files changed, 621 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118257"

@slevenick slevenick requested a review from emilymye June 5, 2020 20:03
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 624 insertions(+))
Terraform Beta: Diff ( 6 files changed, 624 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118276"

},
}

var bigqueryAccessPrimitiveToRoleMap = map[string]string{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - maybe we should move the opposite RoleToPrimativeMap here as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opposite map has the DSF that uses it alongside it, so I'd prefer to keep that together


* `dataset_id` - (Required) The dataset ID, in the form `projects/{project}/datasets/{dataset_id}`

* `member/members` - (Required) Identities that will be granted the privilege in `role`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • bigquery special members?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 627 insertions(+))
Terraform Beta: Diff ( 6 files changed, 627 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118792"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 627 insertions(+))
Terraform Beta: Diff ( 6 files changed, 627 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118794"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_bigquery_dataset_iam_member
4 participants