Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHARED_LOADBALANCER_VIP as option for google_compute_address.purpose #3629

Merged
merged 4 commits into from
Jun 18, 2020

Conversation

edwardmedia
Copy link
Contributor

@edwardmedia edwardmedia commented Jun 11, 2020

Fixes hashicorp/terraform-provider-google#6499

Release Note Template for Downstream PRs (will be copied)

Add SHARED_LOADBALANCER_VIP as option for google_compute_address.purpose (beta only)

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 16 insertions(+))
Terraform Beta: Diff ( 3 files changed, 51 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))
Inspec: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=119513"

@edwardmedia edwardmedia requested review from danawillow and removed request for nat-henderson June 12, 2020 15:07
products/compute/api.yaml Outdated Show resolved Hide resolved
products/compute/api.yaml Show resolved Hide resolved
products/compute/terraform.yaml Show resolved Hide resolved
add `an`

Co-authored-by: Dana Hoffman <danahoffman@google.com>
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@emilymye, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 16 insertions(+))
Terraform Beta: Diff ( 3 files changed, 51 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))
Inspec: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=121411"

Re-ordered the sentences, providing  `when using an Internal address` is applied to all options in the field `purpose`
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 16 insertions(+))
Terraform Beta: Diff ( 3 files changed, 51 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))
Inspec: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=121412"

@edwardmedia edwardmedia requested a review from danawillow June 18, 2020 14:13
skip_docs is applied on internal_with_shared_loadbalancer_vip
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 3 files changed, 35 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))
Inspec: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=121436"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SHARED_LOADBALANCER_VIP as option for google_compute_address.purpose
4 participants