-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added descriptions #3649
added descriptions #3649
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @emilymye, please review this PR or find an appropriate assignee. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120799" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120800" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120838" |
I see this is what failed in the build:
@emilymye , @danawillow , any suggestions? |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=121458" |
It appears as though I accidentally removed an import, I have added it back and the build succeeded. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=122672" |
@@ -60,11 +63,13 @@ func resourceComputeSecurityPolicy() *schema.Resource { | |||
Type: schema.TypeString, | |||
Required: true, | |||
ValidateFunc: validation.StringInSlice([]string{"allow", "deny(403)", "deny(404)", "deny(502)"}, false), | |||
Description: `Action to take when match matches the request. Valid values: "allow" : allow access to target`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to include the other enum values
Adds descriptions for the following resources:
google_compute_network_peering
google_compute_router_interface
google_compute_security_policy
google_compute_target_pool
google_dns_record_set
google_folder
google_project
google_service_account
google_service_networking_connection
google_sql_ssl_cert
google_sql_user
google_storage_notification
google_storage_transfer_job
google_compute_shared_vpc_host_project
google_compute_shared_vpc_service_project