Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added descriptions #3649

Merged
merged 4 commits into from
Jun 26, 2020
Merged

added descriptions #3649

merged 4 commits into from
Jun 26, 2020

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Jun 16, 2020

Adds descriptions for the following resources:

google_compute_network_peering
google_compute_router_interface
google_compute_security_policy
google_compute_target_pool
google_dns_record_set
google_folder
google_project
google_service_account
google_service_networking_connection
google_sql_ssl_cert
google_sql_user
google_storage_notification
google_storage_transfer_job
google_compute_shared_vpc_host_project
google_compute_shared_vpc_service_project

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@emilymye, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 157 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 15 files changed, 157 insertions(+), 23 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120799"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 157 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 15 files changed, 157 insertions(+), 23 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120800"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 370 insertions(+), 236 deletions(-))
Terraform Beta: Diff ( 15 files changed, 370 insertions(+), 236 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120838"

@AlexBulankou
Copy link

I see this is what failed in the build:

# github.com/terraform-providers/terraform-provider-google-beta/google-beta
google-beta/resource_compute_security_policy.go:205:61: cannot use securityPolicy (type *"google.golang.org/api/compute/v1".SecurityPolicy) as type *"google.golang.org/api/compute/v0.beta".SecurityPolicy in argument to config.clientComputeBeta.SecurityPolicies.Insert
google-beta/resource_compute_security_policy.go:241:67: cannot use securityPolicy.Rules (type []*"google.golang.org/api/compute/v0.beta".SecurityPolicyRule) as type []*"google.golang.org/api/compute/v1".SecurityPolicyRule in argument to flattenSecurityPolicyRules
google-beta/resource_compute_security_policy.go:267:61: cannot use securityPolicy (type *"google.golang.org/api/compute/v1".SecurityPolicy) as type *"google.golang.org/api/compute/v0.beta".SecurityPolicy in argument to config.clientComputeBeta.SecurityPolicies.Patch
google-beta/resource_compute_security_policy.go:295:103: cannot use expandSecurityPolicyRule(rule) (type *"google.golang.org/api/compute/v1".SecurityPolicyRule) as type *"google.golang.org/api/compute/v0.beta".SecurityPolicyRule in argument to config.clientComputeBeta.SecurityPolicies.AddRule
google-beta/resource_compute_security_policy.go:307:105: cannot use expandSecurityPolicyRule(rule) (type *"google.golang.org/api/compute/v1".SecurityPolicyRule) as type *"google.golang.org/api/compute/v0.beta".SecurityPolicyRule in argument to config.clientComputeBeta.SecurityPolicies.PatchRule
note: module requires Go 1.14
GNUmakefile:9: recipe for target 'build' failed

@emilymye , @danawillow , any suggestions?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 369 insertions(+), 235 deletions(-))
Terraform Beta: Diff ( 15 files changed, 369 insertions(+), 235 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=121458"

@trodge
Copy link
Contributor Author

trodge commented Jun 18, 2020

I see this is what failed in the build:

# github.com/terraform-providers/terraform-provider-google-beta/google-beta
google-beta/resource_compute_security_policy.go:205:61: cannot use securityPolicy (type *"google.golang.org/api/compute/v1".SecurityPolicy) as type *"google.golang.org/api/compute/v0.beta".SecurityPolicy in argument to config.clientComputeBeta.SecurityPolicies.Insert
google-beta/resource_compute_security_policy.go:241:67: cannot use securityPolicy.Rules (type []*"google.golang.org/api/compute/v0.beta".SecurityPolicyRule) as type []*"google.golang.org/api/compute/v1".SecurityPolicyRule in argument to flattenSecurityPolicyRules
google-beta/resource_compute_security_policy.go:267:61: cannot use securityPolicy (type *"google.golang.org/api/compute/v1".SecurityPolicy) as type *"google.golang.org/api/compute/v0.beta".SecurityPolicy in argument to config.clientComputeBeta.SecurityPolicies.Patch
google-beta/resource_compute_security_policy.go:295:103: cannot use expandSecurityPolicyRule(rule) (type *"google.golang.org/api/compute/v1".SecurityPolicyRule) as type *"google.golang.org/api/compute/v0.beta".SecurityPolicyRule in argument to config.clientComputeBeta.SecurityPolicies.AddRule
google-beta/resource_compute_security_policy.go:307:105: cannot use expandSecurityPolicyRule(rule) (type *"google.golang.org/api/compute/v1".SecurityPolicyRule) as type *"google.golang.org/api/compute/v0.beta".SecurityPolicyRule in argument to config.clientComputeBeta.SecurityPolicies.PatchRule
note: module requires Go 1.14
GNUmakefile:9: recipe for target 'build' failed

@emilymye , @danawillow , any suggestions?

It appears as though I accidentally removed an import, I have added it back and the build succeeded.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 369 insertions(+), 235 deletions(-))
Terraform Beta: Diff ( 15 files changed, 369 insertions(+), 235 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=122672"

@@ -60,11 +63,13 @@ func resourceComputeSecurityPolicy() *schema.Resource {
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{"allow", "deny(403)", "deny(404)", "deny(502)"}, false),
Description: `Action to take when match matches the request. Valid values: "allow" : allow access to target`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to include the other enum values

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 369 insertions(+), 235 deletions(-))
Terraform Beta: Diff ( 15 files changed, 369 insertions(+), 235 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants