Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service is part of the URL and therefore is required. #3720

Merged

Conversation

nat-henderson
Copy link
Contributor

@nat-henderson nat-henderson commented Jun 29, 2020

Release Note Template for Downstream PRs (will be copied)

`app_engine_flexible_app_version` and `app_engine_standard_app_version` now require `service` to be set.  Before this change, leaving the value empty would have passed validation but failed during apply.

Fixes hashicorp/terraform-provider-google#6711

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 20 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 4 files changed, 20 insertions(+), 20 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=127012"

@nat-henderson nat-henderson requested a review from megan07 June 29, 2020 21:53
@nat-henderson nat-henderson merged commit 6be59d3 into GoogleCloudPlatform:master Jun 30, 2020
@nat-henderson nat-henderson deleted the tf-app-service branch June 30, 2020 17:48
tishen25 added a commit to tishen25/magic-modules that referenced this pull request Jun 30, 2020
Service is part of the URL and therefore is required. (GoogleCloudPlatform#3720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app_engine_flexible_app_version service should be a required field or have a default value
3 participants