Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created game server rollout data source #3727

Merged
merged 6 commits into from
Jul 8, 2020

Conversation

edwardmedia
Copy link
Contributor

@edwardmedia edwardmedia commented Jul 2, 2020

Fixes hashicorp/terraform-provider-google#6463

Release Note Template for Downstream PRs (will be copied)

google_game_services_game_server_deployment_rollout (beta only)

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@danawillow, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 90 insertions(+))
Terraform Beta: Diff ( 5 files changed, 289 insertions(+), 69 deletions(-))

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data source itself looks good! Had some comments on the tests/docs.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 90 insertions(+))
Terraform Beta: Diff ( 5 files changed, 251 insertions(+), 69 deletions(-))

2 similar comments
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 90 insertions(+))
Terraform Beta: Diff ( 5 files changed, 251 insertions(+), 69 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 90 insertions(+))
Terraform Beta: Diff ( 5 files changed, 251 insertions(+), 69 deletions(-))

@edwardmedia edwardmedia requested a review from danawillow July 7, 2020 16:25
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test currently fails:

------- Stdout: -------
=== RUN   TestAAccDataSourceGameServicesGameServerDeploymentRollout_basic
=== PAUSE TestAAccDataSourceGameServicesGameServerDeploymentRollout_basic
=== CONT  TestAAccDataSourceGameServicesGameServerDeploymentRollout_basic
TestAAccDataSourceGameServicesGameServerDeploymentRollout_basic: testing.go:674: Step 0 error: Check failed: Check 1/1 error: default_game_server_config is ; want projects/ci-test-project-188019/locations/global/gameServerDeployments/tf-test-deployment-8y7vmsgrfv/configs/tf-test-config-8y7vmsgrfv
--- FAIL: TestAAccDataSourceGameServicesGameServerDeploymentRollout_basic (66.65s)
FAIL

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 90 insertions(+))
Terraform Beta: Diff ( 5 files changed, 251 insertions(+), 69 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 90 insertions(+))
Terraform Beta: Diff ( 5 files changed, 251 insertions(+), 69 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game server rollout data source
4 participants