-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created game server rollout data source #3727
Created game server rollout data source #3727
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @danawillow, please review this PR or find an appropriate assignee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data source itself looks good! Had some comments on the tests/docs.
...d_party/terraform/tests/data_google_game_services_game_server_deployment_rollout_test.go.erb
Outdated
Show resolved
Hide resolved
third_party/terraform/website/docs/d/game_services_game_server_deployment_rollout.html.markdown
Outdated
Show resolved
Hide resolved
third_party/terraform/website/docs/d/game_services_game_server_deployment_rollout.html.markdown
Outdated
Show resolved
Hide resolved
third_party/terraform/website/docs/d/game_services_game_server_deployment_rollout.html.markdown
Outdated
Show resolved
Hide resolved
…go.erb Replace the custom check
fix the indentation
2 similar comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test currently fails:
------- Stdout: -------
=== RUN TestAAccDataSourceGameServicesGameServerDeploymentRollout_basic
=== PAUSE TestAAccDataSourceGameServicesGameServerDeploymentRollout_basic
=== CONT TestAAccDataSourceGameServicesGameServerDeploymentRollout_basic
TestAAccDataSourceGameServicesGameServerDeploymentRollout_basic: testing.go:674: Step 0 error: Check failed: Check 1/1 error: default_game_server_config is ; want projects/ci-test-project-188019/locations/global/gameServerDeployments/tf-test-deployment-8y7vmsgrfv/configs/tf-test-config-8y7vmsgrfv
--- FAIL: TestAAccDataSourceGameServicesGameServerDeploymentRollout_basic (66.65s)
FAIL
...d_party/terraform/tests/data_google_game_services_game_server_deployment_rollout_test.go.erb
Outdated
Show resolved
Hide resolved
…go.erb Update the test
…go.erb Fix a typo
Fixes hashicorp/terraform-provider-google#6463
Release Note Template for Downstream PRs (will be copied)