Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional documentation about how to easily get started with credentials in the provider. #3740

Merged
merged 2 commits into from
Jul 20, 2020

Conversation

nat-henderson
Copy link
Contributor

fixes hashicorp/terraform-provider-google#6780

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 18 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 18 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=132856"

if c, err := googleoauth.DefaultTokenSource(context.Background(), clientScopes...); err == nil {
return c, err
} else {
return c, fmt.Errorf("Attempted to load application default credentials since neither `credentials` nor `access_token` was set in the provider block. No credentials loaded. Consider running 'gcloud auth application-default login. Original error: %w", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return c, fmt.Errorf("Attempted to load application default credentials since neither `credentials` nor `access_token` was set in the provider block. No credentials loaded. Consider running 'gcloud auth application-default login. Original error: %w", err)
return c, fmt.Errorf("Attempted to load application default credentials since neither `credentials` nor `access_token` was set in the provider block. No credentials loaded. Consider running 'gcloud auth application-default login'. Original error: %w", err)

[manage key files using the Cloud Console].
[manage key files using the Cloud Console]. If not provided, the
application default credentials will be used. You can configure
use Application Default Credentials on your personal machine by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use Application Default Credentials on your personal machine by
Application Default Credentials on your personal machine by

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigQueryTable_HivePartitioningCustomSchema|TestAccEndpointsService_basic|TestAccServiceAccountIamMember_withAndWithoutCondition|TestAccServiceAccountIamBinding_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=132859"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=132861"

@danawillow
Copy link
Contributor

FYI I just merged in a change with a conflict to config.go.erb, shouldn't be too bad to resolve.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 22 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 22 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134003"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccEndpointsService_basic|TestAccServiceAccountIamMember_withAndWithoutCondition|TestAccServiceAccountIamBinding_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134043"

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks Nathan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UX when a service account isn't used.
5 participants