Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add os config guest policies #3743

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jul 14, 2020

Fixes hashicorp/terraform-provider-google#6464

Release Note Template for Downstream PRs (will be copied)

`google_os_config_guest_policies`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 8 files changed, 4555 insertions(+), 5 deletions(-))
TF OiCS: Diff ( 12 files changed, 428 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=133105"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigQueryTable_HivePartitioningCustomSchema|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccServiceAccountIamBinding_withAndWithoutCondition|TestAccServiceAccountIamMember_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=133109"

@megan07 megan07 requested a review from rileykarson July 14, 2020 20:51
base_url: "projects/{{project}}/guestPolicies"
create_url: "projects/{{project}}/guestPolicies?guestPolicyId={{guest_policy_id}}"
update_verb: :PATCH
self_link: "{{name}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the projects/{project_number}/guestPolicies/{guestPolicyId} form here instead? I think the import format is easier to understand that way. Users are sometimes confused when the format of the import is the name field.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 8 files changed, 4559 insertions(+), 5 deletions(-))
TF OiCS: Diff ( 12 files changed, 428 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=133597"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccEndpointsService_basic|TestAccServiceAccountIamMember_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=133600"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS Config resources
4 participants