-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add os config guest policies #3743
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=133105" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigQueryTable_HivePartitioningCustomSchema|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccServiceAccountIamBinding_withAndWithoutCondition|TestAccServiceAccountIamMember_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=133109" |
products/osconfig/api.yaml
Outdated
base_url: "projects/{{project}}/guestPolicies" | ||
create_url: "projects/{{project}}/guestPolicies?guestPolicyId={{guest_policy_id}}" | ||
update_verb: :PATCH | ||
self_link: "{{name}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use the projects/{project_number}/guestPolicies/{guestPolicyId}
form here instead? I think the import format is easier to understand that way. Users are sometimes confused when the format of the import is the name
field.
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=133597" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccEndpointsService_basic|TestAccServiceAccountIamMember_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=133600" |
Fixes hashicorp/terraform-provider-google#6464
Release Note Template for Downstream PRs (will be copied)