Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring metric descriptor #3754

Merged

Conversation

tishen25
Copy link
Contributor

@tishen25 tishen25 commented Jul 16, 2020

Fixes: hashicorp/terraform-provider-google#3360

Release Note Template for Downstream PRs (will be copied)

`google_monitoring_metric_descriptor`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 1328 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 17 files changed, 1330 insertions(+), 15 deletions(-))
TF Conversion: Diff ( 1 file changed, 213 insertions(+))
TF OiCS: Diff ( 8 files changed, 241 insertions(+))

@slevenick slevenick requested review from slevenick and removed request for nat-henderson July 16, 2020 21:21
products/monitoring/api.yaml Outdated Show resolved Hide resolved
products/monitoring/api.yaml Show resolved Hide resolved
products/monitoring/api.yaml Show resolved Hide resolved
products/monitoring/api.yaml Outdated Show resolved Hide resolved
products/monitoring/api.yaml Outdated Show resolved Hide resolved
products/monitoring/terraform.yaml Outdated Show resolved Hide resolved
third_party/terraform/utils/common_polling.go Show resolved Hide resolved
third_party/terraform/utils/common_polling.go Show resolved Hide resolved
provider/terraform/async.rb Show resolved Hide resolved
third_party/terraform/utils/common_polling.go Show resolved Hide resolved
@tishen25 tishen25 marked this pull request as draft July 17, 2020 16:01
@tishen25 tishen25 force-pushed the monitoring-metric-descriptor branch from 380e0f7 to d3577ff Compare July 17, 2020 22:58
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 1328 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 17 files changed, 1330 insertions(+), 15 deletions(-))
TF Conversion: Diff ( 1 file changed, 213 insertions(+))
TF OiCS: Diff ( 8 files changed, 241 insertions(+))

@tishen25 tishen25 marked this pull request as ready for review July 17, 2020 23:54
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 1334 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 17 files changed, 1336 insertions(+), 15 deletions(-))
TF Conversion: Diff ( 1 file changed, 213 insertions(+))
TF OiCS: Diff ( 8 files changed, 241 insertions(+))

@slevenick slevenick self-requested a review July 20, 2020 23:26
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 1334 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 17 files changed, 1336 insertions(+), 15 deletions(-))
TF Conversion: Diff ( 1 file changed, 213 insertions(+))
TF OiCS: Diff ( 8 files changed, 241 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134418"

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stackdriver Monitoring Custom Metric
5 participants