Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add folder_id as output to folder datasource and resource #3763

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jul 21, 2020

While reviewing the Cloud Asset Feed resources, we found that folder_id might be a helpful output of google_folder

#3750 (comment)

Release Note Template for Downstream PRs (will be copied)

resourcemanager: added `folder_id` as computed attribute to `google_folder` resource and datasource.

@google-cla google-cla bot added the cla: yes label Jul 21, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 13 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 4 files changed, 13 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134586"

@megan07 megan07 requested a review from c2thorn July 21, 2020 20:38
@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample|TestAccCloudAssetOrganizationFeed_cloudAssetOrganizationFeedExample|TestAccCloudAssetProjectFeed_cloudAssetProjectFeedExample|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccServiceAccountIamMember_withAndWithoutCondition|TestAccServiceAccountIamBinding_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134587"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants