Add vpcAccessConnector property on google_app_engine_standard_app_version terraform resource

[dhvogel]

Fixes hashicorp/terraform-provider-google#4988

Release Note Template for Downstream PRs (will be copied)

appengine: added `vpc_access_connector` field to `google_app_engine_standard_app_version` resource

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

[slevenick]

Can you remove the modifications to Gemfile.lock so that this works correctly in our CI?

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 82 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 82 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
Inspec: Diff ( 5 files changed, 46 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=136213"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 82 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 82 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
Inspec: Diff ( 5 files changed, 46 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=136214"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccActiveDirectoryDomain_update|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccMonitoringMetricDescriptor_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=136215"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 180 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 180 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
Inspec: Diff ( 5 files changed, 46 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137819"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 180 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 180 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
Inspec: Diff ( 5 files changed, 46 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137821"

[slevenick]

Tests on generated code are failing due to:

./google-beta/resource_app_engine_standard_app_version_test.go:48:5: missing ',' before newline in composite literal

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 180 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 180 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
Inspec: Diff ( 5 files changed, 46 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137824"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 180 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 180 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
Inspec: Diff ( 5 files changed, 46 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137830"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAppEngineStandardAppVersion_update|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstance_shieldedVmConfig1|TestAccComputeInstance_shieldedVmConfig2|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccRedisInstance_redisInstanceFullExample|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basic_with_user_labels You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137840"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 182 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 182 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
Inspec: Diff ( 5 files changed, 46 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=137871"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 182 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 182 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
Inspec: Diff ( 5 files changed, 46 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138107"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional|TestAccAppEngineStandardAppVersion_update|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_basic|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_misc|TestAccContainerCluster_withInvalidReleaseChannel|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withAddons|TestAccContainerCluster_withMasterAuthConfig|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_regional|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withVersion|TestAccContainerCluster_network|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_backend|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolConflictingNameFields|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerNodePool_basic|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_resize|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_shieldedInstanceConfig|TestAccEndpointsService_basic|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138109"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 182 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 182 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
Inspec: Diff ( 5 files changed, 46 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138132"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerClusterDatasource_regional|TestAccContainerClusterDatasource_zonal|TestAccAppEngineStandardAppVersion_update|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_basic|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withInvalidReleaseChannel|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_misc|TestAccContainerCluster_withMasterAuthConfig|TestAccContainerCluster_withAddons|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_regional|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withVersion|TestAccContainerCluster_network|TestAccContainerCluster_backend|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolConflictingNameFields|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_basic|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_resize|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_shieldedInstanceConfig You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138142"

[CaptainJojo]

Plz we need this PR for https://github.com/EurosportDigital

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 203 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 203 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
Inspec: Diff ( 5 files changed, 46 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=140925"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeInstanceSerialPort_basic|TestAccDataSourceComputeInstance_basic|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccAppEngineStandardAppVersion_update|TestAccComposerEnvironment_basic|TestAccComposerEnvironment_private|TestAccComposerEnvironment_privateWithWebServerControl|TestAccComposerEnvironment_update|TestAccComposerEnvironment_withUpdateOnCreate|TestAccComposerEnvironment_withSoftwareConfig|TestAccComputeAttachedDisk_count|TestAccComposerEnvironment_withNodeConfig|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeHealthCheck_healthCheckGrpcExample|TestAccComputeHealthCheck_healthCheckGrpcFullExample|TestAccComputeInstanceFromTemplate_basic|TestAccComputeRegionDisk_deleteDetach|TestAccComputeRegionHealthCheck_regionHealthCheckGrpcExample|TestAccComputeRegionHealthCheck_regionHealthCheckGrpcFullExample|TestAccRegionInstanceGroupManager_basic|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccMemcacheInstance_update|TestAccMemcacheInstance_memcacheInstanceBasicExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestAddressesExample|TestAccNetworkManagementConnectivityTest_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=140927"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 200 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 200 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
Inspec: Diff ( 5 files changed, 46 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=140957"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeInstanceSerialPort_basic|TestAccDataSourceComputeInstance_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccComposerEnvironment_update|TestAccComputeHealthCheck_healthCheckGrpcExample|TestAccComputeHealthCheck_healthCheckGrpcFullExample|TestAccComputeInstanceFromTemplate_basic|TestAccComputeRegionHealthCheck_regionHealthCheckGrpcExample|TestAccComputeRegionHealthCheck_regionHealthCheckGrpcFullExample|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withInvalidKubeletCpuManagerPolicy|TestAccContainerNodePool_withLinuxNodeConfig|TestAccMemcacheInstance_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=140959"