-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for v1 game servers. #3790
Conversation
Hello, |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ndmckinley, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 27 files changed, 4456 insertions(+), 69 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution! Would you mind pinging me when you want this released? I don't usually get the request to delay a merge so my normal workflow doesn't have a slot for "things waiting until $date". If it's too much bother I'll just make a calendar event or something.
Happy to that. Thank you! |
Hello @ndmckinley , please go ahead and merge. |
Great, running the tests now. |
Hmm, @pjayara-g, the tests are failing on our CI cluster. Are they passing for you, locally? |
Sync from upstream
Merge from origin
Any way to see what failed? |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 27 files changed, 4472 insertions(+), 69 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 27 files changed, 4472 insertions(+), 69 deletions(-)) |
We've gotten this running and @pjayara-g confirms that tests are passing locally in both beta and GA. :) Going to submit - there may be some test infrastructure we need to set up on our side afterwards, but in the meantime, thanks for your work, @pjayara-g! |
Release Note Template for Downstream PRs (will be copied)