Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for v1 game servers. #3790

Merged
merged 5 commits into from
Aug 7, 2020

Conversation

pjayara-g
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

`gameservices: Added new resource `google_game_services_realm`
`gameservices: Added new resource `google_game_services_game_server_cluster`
`gameservices: Added new resource `google_game_services_game_server_config`
`gameservices: Added new resource `google_game_services_game_server_deployment`
`gameservices: Added new resource `google_game_services_game_server_deployment_rollout`

@google-cla google-cla bot added the cla: yes label Jul 28, 2020
@pjayara-g
Copy link
Contributor Author

Hello,
I would like this merged after August 5th please.
Thanks

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 4456 insertions(+), 69 deletions(-))
Terraform Beta: Diff ( 12 files changed, 51 insertions(+), 73 deletions(-))
TF Conversion: Diff ( 6 files changed, 679 insertions(+))
TF OiCS: Diff ( 5 files changed, 17 deletions(-))

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution! Would you mind pinging me when you want this released? I don't usually get the request to delay a merge so my normal workflow doesn't have a slot for "things waiting until $date". If it's too much bother I'll just make a calendar event or something.

@pjayara-g
Copy link
Contributor Author

Happy to that. Thank you!

@pjayara-g
Copy link
Contributor Author

Hello @ndmckinley , please go ahead and merge.

@nat-henderson
Copy link
Contributor

Great, running the tests now.

@nat-henderson
Copy link
Contributor

Hmm, @pjayara-g, the tests are failing on our CI cluster. Are they passing for you, locally?

@pjayara-g
Copy link
Contributor Author

Any way to see what failed?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 4472 insertions(+), 69 deletions(-))
Terraform Beta: Diff ( 12 files changed, 51 insertions(+), 73 deletions(-))
TF Conversion: Diff ( 6 files changed, 679 insertions(+))
TF OiCS: Diff ( 5 files changed, 17 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 4472 insertions(+), 69 deletions(-))
Terraform Beta: Diff ( 18 files changed, 67 insertions(+), 89 deletions(-))
TF Conversion: Diff ( 6 files changed, 679 insertions(+))
TF OiCS: Diff ( 5 files changed, 17 deletions(-))

@nat-henderson
Copy link
Contributor

We've gotten this running and @pjayara-g confirms that tests are passing locally in both beta and GA. :) Going to submit - there may be some test infrastructure we need to set up on our side afterwards, but in the meantime, thanks for your work, @pjayara-g!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants