-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pd-balanced disk type #3827
Add support for pd-balanced disk type #3827
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @slevenick, please review this PR or find an appropriate assignee. |
Any chance of this getting a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than a small typo!
Yup, sorry I had done a partial review and then forgot about this |
Co-authored-by: Sam Levenick <slevenick@google.com>
It is ready to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition!
Release Note Template for Downstream PRs (will be copied)
Fixes: hashicorp/terraform-provider-google#6878
I'll check other resources such as Dataproc and Dataflow and see if any validation is on the diskType fields if they are allowed to be provided.