Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pd-balanced disk type #3827

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Aug 5, 2020

Release Note Template for Downstream PRs (will be copied)
Fixes: hashicorp/terraform-provider-google#6878

I'll check other resources such as Dataproc and Dataflow and see if any validation is on the diskType fields if they are allowed to be provided.

compute: added support for pd-balanced disk type for `google_compute_instance`
container: added support for pd-balanced disk type for `google_container_node_pool`

@google-cla google-cla bot added the cla: yes label Aug 5, 2020
@upodroid upodroid changed the title Add support for pd-balanced. Add support for pd-balanced disk type Aug 5, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 7 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 6 files changed, 7 insertions(+), 7 deletions(-))

@hanikesn
Copy link

Any chance of this getting a review?

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than a small typo!

products/compute/api.yaml Outdated Show resolved Hide resolved
@slevenick
Copy link
Contributor

Any chance of this getting a review?

Yup, sorry I had done a partial review and then forgot about this

Co-authored-by: Sam Levenick <slevenick@google.com>
@upodroid
Copy link
Contributor Author

It is ready to go

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 7 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 6 files changed, 7 insertions(+), 7 deletions(-))

@slevenick slevenick self-requested a review August 25, 2020 20:49
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for pd-balanced storage option
4 participants