-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DSFs to references in snapshot tests (and other MM-generated tests) #3930
Add DSFs to references in snapshot tests (and other MM-generated tests) #3930
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143074" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceComputeBackendBucket_basic|TestAccCloudFunctionsCloudFunctionIamBindingGenerated|TestAccCloudFunctionsCloudFunctionIamMemberGenerated|TestAccCloudFunctionsCloudFunctionIamPolicyGenerated|TestAccIapAppEngineVersionIamBindingGenerated|TestAccIapAppEngineVersionIamMemberGenerated|TestAccIapAppEngineVersionIamBindingGenerated_withCondition|TestAccIapAppEngineVersionIamMemberGenerated_withCondition|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccIapAppEngineVersionIamPolicyGenerated_withCondition|TestAccIapAppEngineServiceIamBindingGenerated|TestAccIapAppEngineServiceIamMemberGenerated|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample|TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample|TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample|TestAccBigQueryJob_bigqueryJobExtractExample|TestAccBigQueryJob_bigqueryJobExtractTableReferenceExample|TestAccAppEngineStandardAppVersion_update|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccAppEngineFlexibleAppVersion_update|TestAccBigQueryTable_HivePartitioning|TestAccBigQueryTable_HivePartitioningCustomSchema|TestAccBigQueryExternalDataTable_CSV|TestAccCloudFunctionsFunction_basic|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_firestore|TestAccCloudFunctionsFunction_pubsub|TestAccCloudFunctionsFunction_bucket|TestAccCloudFunctionsFunction_serviceAccountEmail|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeBackendBucket_backendBucketBasicExample|TestAccComputeBackendBucket_basicModified|TestAccComputeBackendBucket_withCdnPolicy|TestAccComputeBackendBucketSignedUrlKey_basic|TestAccComputeDisk_VSSWindows|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeUrlMap_urlMapBasicExample|TestAccDataprocCluster_withStagingBucket|TestAccDataprocCluster_withInitAction|TestAccDataprocCluster_withKerberos|TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccLoggingBillingAccountSink_basic|TestAccLoggingBillingAccountSink_update|TestAccLoggingBillingAccountSink_heredoc|TestAccLoggingFolderSink_basic|TestAccLoggingFolderSink_removeOptionals|TestAccLoggingFolderSink_folderAcceptsFullFolderPath|TestAccLoggingFolderSink_update|TestAccLoggingFolderSink_heredoc|TestAccLoggingOrganizationSink_basic|TestAccLoggingOrganizationSink_update|TestAccLoggingOrganizationSink_heredoc|TestAccLoggingProjectSink_basic|TestAccLoggingProjectSink_updatePreservesUniqueWriter|TestAccLoggingProjectSink_heredoc|TestAccComputeResourceUsageExportBucket You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143081" |
This makes resources that are compliant with hashicorp/terraform-provider-google#4328 pass the import step.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)