-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow google.project.id for passing project to resource_project_service #3975
Allow google.project.id for passing project to resource_project_service #3975
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145870" |
…-modules into scsuarez/flexibility-with-resource-google-project-service Merge with Master .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor qusetions/nitpicks about self link related funcs!
third_party/terraform/resources/resource_google_project_service.go
Outdated
Show resolved
Hide resolved
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145873" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145874" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeRegionSslCertificate|TestAccComputeSnapshot_encryptionCMEK|TestAccDataCatalogTag_dataCatalogEntryGroupTagExample|TestAccDataCatalogTag_dataCatalogEntryTagBasicExample|TestAccDataCatalogTag_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145877" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeRegionSslCertificate|TestAccComputeSnapshot_encryptionCMEK|TestAccDataCatalogTag_dataCatalogEntryTagBasicExample|TestAccDataCatalogTag_dataCatalogEntryGroupTagExample|TestAccDataCatalogTag_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145878" |
Added ability to pass google.project.id to google.project_service.project
Fixes 7203
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)