-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add taxonomy and policy_tag resources to data_catalog product #4076
Add taxonomy and policy_tag resources to data_catalog product #4076
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ndmckinley, please review this PR or find an appropriate assignee. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151334" |
Happy to review - I'm not sure if github will notify me when you convert from a draft to ready-for-review, so please ping me when you do so I know to come back to this. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152380" |
…-modules into add-taxonomy-resource-to-magic-modules
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152984" |
templates/terraform/examples/data_catalog_taxonomies_policy_tag_child_policies.tf.erb
Outdated
Show resolved
Hide resolved
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153091" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153091" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for IAM support!
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153238" |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153239" |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153242" |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153329" |
…-modules into add-taxonomy-resource-to-magic-modules
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153376" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic|TestAccDataCatalogPolicyTagIamBindingGenerated|TestAccDataCatalogPolicyTagIamMemberGenerated|TestAccDataCatalogPolicyTagIamPolicyGenerated|TestAccDataCatalogTaxonomyIamBindingGenerated|TestAccDataCatalogEntryGroupIamBindingGenerated|TestAccDataCatalogTaxonomyIamPolicyGenerated|TestAccDataCatalogTaxonomyIamMemberGenerated|TestAccDataCatalogEntryGroupIamMemberGenerated|TestAccDataCatalogEntryGroupIamPolicyGenerated|TestAccDataCatalogEntry_dataCatalogEntryBasicExample|TestAccDataCatalogEntry_dataCatalogEntryFilesetExample|TestAccDataCatalogEntry_dataCatalogEntryFullExample|TestAccDataCatalogEntryGroup_dataCatalogEntryGroupBasicExample|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagBasicExample|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagChildPoliciesExample|TestAccDataCatalogEntryGroup_dataCatalogEntryGroupFullExample|TestAccDataCatalogEntryGroup_update|TestAccDataCatalogTaxonomy_dataCatalogTaxonomyBasicExample|TestAccDataCatalogEntry_update|TestAccDataCatalogTag_dataCatalogEntryTagBasicExample|TestAccDataCatalogTag_dataCatalogEntryGroupTagExample|TestAccDataCatalogTag_dataCatalogEntryTagFalseExample|TestAccDataCatalogTagTemplate_dataCatalogTagTemplateBasicExample|TestAccDataCatalogTag_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153407" |
Adding taxonomy and policy_tag resources to product_data_catalog
Closes 6075
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)