Add support for google_project_default_service_accounts resource

[rileykarson]

Upstreams hashicorp/terraform-provider-google#7541, Fixes hashicorp/terraform-provider-google#4135

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_project_default_service_accounts`

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[rileykarson]

This modifies third_party files where the CLA does not apply.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 529 insertions(+))
Terraform Beta: Diff ( 6 files changed, 529 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=155048"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic|TestAccBigqueryDataTransferConfig|TestAccResourceGoogleProjectDefaultServiceAccountsBasic|TestAccResourceGoogleProjectDefaultServiceAccountsDisable|TestAccResourceGoogleProjectDefaultServiceAccountsDelete|TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=155050"

[thiagonache]

@google-admin Please, do not merge it. there's a bug in the implementation.

[upodroid]

It is probably worth having a note at the top of the docs that notes that there is a constraint that can deprivilege the default GCE/GAE service account.

[c2thorn]

Although I'm pretty much just here to rubberstamp, is this ready for review? Or are we expecting changes to the downstream

[rileykarson]

We're good! We worked out in the downstream that this is good as is. @thiagonache had a proposal that would have reduced the number of errors for REVERT restore_policy deletes, but I think we're in agreement that we're comfortable without including it.

@upodroid: I don't feel that strongly that we should include it- we don't enumerate what org policies conflict / apply to other resources- but feel free to PR it in after, though!

[c2thorn]

This is the handwritten-est resource ever

[c2thorn]

Is this doing something different that what is achieved here: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/third_party/terraform/utils/provider_test.go.erb#L538

[rileykarson]

I'll change the other one to use the new function as a followup.

[thiagonache]

I was requested to create a function in order to make the function more readable on the review process. It is a simple sleep

…

On 30 Oct 2020, at 19:03, Cameron Thornton ***@***.***> wrote:  @c2thorn approved this pull request. This is the handwritten-est resource ever In third_party/terraform/utils/provider_test.go.erb: > @@ -947,3 +947,10 @@ func skipIfVcr(t *testing.T) { t.Skipf("VCR enabled, skipping test: %s", t.Name()) } } + +func sleepInSecondsForTest(t int) resource.TestCheckFunc { Is this doing something different that what is achieved here: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/third_party/terraform/utils/provider_test.go.erb#L538 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[rileykarson]

@c2thorn: Agreed!