-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ForceOverride as ignore read as it does not appear in response #4304
ForceOverride as ignore read as it does not appear in response #4304
Conversation
Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=162444" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nested ignore_read
fields have never actually worked, fun fact! You can use a custom flattener that draws the value from the old state. Since this is within an object, we just need to d.Get("spec.0.force_override")
(or whatever nested paths look like)
0ca3e71
to
dfa126e
Compare
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=163298" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=163302" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceStorageBucketObjectContent_Basic|TestAccDataSourceSpannerInstance_basic|TestAccDataSourceSqlDatabaseInstance_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBillingBudget_billingBudgetLastperiodExample|TestAccBillingBudget_billingBudgetNotifyExample|TestAccBillingBudget_billingBudgetFilterExample|TestAccBillingBudget_billingBudgetBasicExample|TestAccBigqueryDataTransferConfig|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccCloudSchedulerJob_schedulerJobHttpExample|TestAccComposerEnvironment_withUpdateOnCreate|TestAccOSLoginSSHPublicKey_osLoginSshKeyExpiry|TestAccSQLDatabase_sqlDatabaseBasicExample|TestAccSqlDatabaseInstance_basicSecondGen|TestAccSqlDatabaseInstance_basicMSSQL|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_diskspecs|TestAccSqlDatabaseInstance_maintenance|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSpannerDatabase_basic|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccSqlDatabaseInstance_multipleOperations|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabase_basic|TestAccSqlClientCert_mysql|TestAccSqlDatabase_update|TestAccSqlClientCert_postgres|TestAccSqlUser_postgres|TestAccSqlDatabaseInstance_withPrivateNetwork|TestAccSqlUser_postgresAbandon You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=163392" |
Fixes: hashicorp/terraform-provider-google#7973
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)