Removed trailing references to kubernetes_dashboard #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed in GoogleCloudPlatform#2551 as one of the v3 breaking changes. However, a few trailing references remained in the repository. Removing those should bring us back in line and will resolve some broken tests in terraform-validator.
melinath
requested review from
a team and
nat-henderson
and removed request for
a team
Closed
10 tasks
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=163487" |
nat-henderson
approved these changes
Dec 16, 2020
This was referenced Dec 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes_dashboardwas removed in #2551 as one of the v3 breaking changes. However, a few trailing references remained in the repository. Removing those should bring us back in line and will resolve some broken tests in terraform-validator.Related to GoogleCloudPlatform/terraform-validator#158
Release Note Template for Downstream PRs (will be copied)