Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong initialization of maintenance_exclusion #4372

Conversation

msgongora
Copy link
Contributor

This PR fixes hashicorp/terraform-provider-google/issues/8112

Release Note Template for Downstream PRs (will be copied)

container: Fix crash due to nil exclusions object when updating an existent cluster with maintenance_policy but without exclusions

@google-cla google-cla bot added the cla: yes label Jan 6, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 11 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 2 files changed, 12 insertions(+), 9 deletions(-))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @msgongora!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider crashes updating existing gke cluster by adding maintenance_exclusion
3 participants