add transit encryption mode support for redis instance resource

[venkykuberan]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

redis: Added support for transit encryption mode for the resource `google_redis_instance`

fixes hashicorp/terraform-provider-google#8060

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 44 insertions(+))
Terraform Beta: Diff ( 4 files changed, 45 insertions(+), 1 deletion(-))
Ansible: Diff ( 2 files changed, 30 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
Inspec: Diff ( 4 files changed, 9 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=169819"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 44 insertions(+))
Terraform Beta: Diff ( 4 files changed, 45 insertions(+), 1 deletion(-))
Ansible: Diff ( 2 files changed, 30 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
Inspec: Diff ( 4 files changed, 10 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=170308"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRedisInstanceDatasource_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityCmekExample|TestAccRedisInstance_redisInstanceBasicExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_regionFromLocation|TestAccRedisInstance_update|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccRedisInstance_redisInstanceAuthEnabled You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=170310"

[rileykarson]

One addtl quick note as I'm rounding out some triage, we should add the server_ca_certs output field in this PR too.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 44 insertions(+))
Terraform Beta: Diff ( 3 files changed, 44 insertions(+))
Ansible: Diff ( 2 files changed, 30 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
Inspec: Diff ( 4 files changed, 10 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171771"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 35 insertions(+))
Terraform Beta: Diff ( 3 files changed, 35 insertions(+))
Ansible: Diff ( 2 files changed, 28 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
Inspec: Diff ( 4 files changed, 10 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171773"

[rileykarson]

transit_encryption_mode LGTM, but see #4444 (review) - I think we need to add some output only fields as well and I'd prefer we do it in this PR

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRedisInstance_update|TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171776"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceAuthEnabled You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171786"

[venkykuberan]

transit_encryption_mode LGTM, but see #4444 (review) - I think we need to add some output only fields as well and I'd prefer we do it in this PR
added the server_ca_certs as part of this PR

[rileykarson]

@slevenick any idea what this error is about? https://console.cloud.google.com/cloud-build/builds/eec8061e-2d56-4995-b3ae-be46aab37a82;step=15?project=graphite-docker-images

[venkykuberan]

done

[slevenick]

/gcbrun

Not sure why this is happening but the magician isn't making folders as necessary for inspec property parsing. I manually made the folder so this should work now

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 34 insertions(+))
Terraform Beta: Diff ( 3 files changed, 140 insertions(+))
Inspec: Diff ( 4 files changed, 28 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172006"

[rileykarson]

Can you mark each subproperty here output: true as well? That'll make this schema a little more correct: auto-pr-4444-old..auto-pr-4444#diff-fd32ba4f30

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataprocJob_PySpark|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccRedisInstance_redisInstanceAuthEnabled You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172012"

[modular-magician]

Tests failed during RECORDING mode: TestAccRedisInstance_redisInstancePrivateServiceExample Please fix these to complete your PR

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 29 insertions(+))
Terraform Beta: Diff ( 3 files changed, 135 insertions(+))
Inspec: Diff ( 4 files changed, 28 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172042"