-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deletion protection for big_query_table #4478
add deletion protection for big_query_table #4478
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 10 files changed, 227 insertions(+), 54 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171463" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we'll want to set the value to true
on import, similar to https://github.com/hashicorp/terraform-provider-google/pull/7557/files#diff-297ee965811f5832a0792c8c36452f5b9f15f07f969574c00c5acf9d487abacaR420-R424
mmv1/templates/terraform/examples/bigquery_dataset_access_view.tf.erb
Outdated
Show resolved
Hide resolved
mmv1/templates/terraform/examples/bigquery_bigquery_table.tf.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_bigquery_table_test.go
Outdated
Show resolved
Hide resolved
@rileykarson thanks for your patience on this. I've unified the tabs vs spaces implementation and set the virtual field on import |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 11 files changed, 459 insertions(+), 281 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172035" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ScottSuarez!
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigQueryTable_allowDestroy|TestAccDataprocJob_PySpark You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172039" |
adding deletion protection to stop tables from being accidentally dropped
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)