-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google_dataproc_metastore_service #4486
Add google_dataproc_metastore_service #4486
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 281 insertions(+), 3 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172034" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a handwritten test that tests the update functionality & import step?
mmv1/third_party/terraform/utils/dataproc_metastore_service_diff_supress.go.erb
Show resolved
Hide resolved
mmv1/third_party/terraform/utils/dataproc_metastore_service_diff_supress.go.erb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commenting in turn
mmv1/third_party/terraform/utils/dataproc_metastore_service_diff_supress.go.erb
Show resolved
Hide resolved
mmv1/third_party/terraform/utils/dataproc_metastore_service_diff_supress.go.erb
Show resolved
Hide resolved
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 247 insertions(+), 3 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172127" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 250 insertions(+), 3 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172216" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeGlobalAddress_globalAddressPrivateServicesConnectExample|TestAccComputeGlobalForwardingRule_globalForwardingRulePrivateServicesConnectExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample|TestAccDataprocMetastoreService_updateAndImport|TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172218" |
Tests failed during RECORDING mode: TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccDataprocMetastoreService_updateAndImport|TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample Please fix these to complete your PR |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 250 insertions(+), 3 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172757" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample|TestAccDataprocMetastoreService_updateAndImport|TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=172761" |
Tests failed during RECORDING mode: TestAccRedisInstance_redisInstancePrivateServiceExample Please fix these to complete your PR |
@slevenick should be good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple little notes on the api.yaml file and ensuring we don't allow empty blocks. Also if you rebase it should fix the rake test issue
mmv1/templates/terraform/examples/dataproc_metastore_service_basic.tf.erb
Outdated
Show resolved
Hide resolved
…-modules into scsuarez/add-dataproc-metastore-service
Hey @slevenick, thanks for being so thorough ! I went ahead and updated things |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 229 insertions(+), 3 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=173368" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 229 insertions(+), 3 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=173369" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample|TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=173371" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample|TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=173372" |
Tests failed during RECORDING mode: TestAccRedisInstance_redisInstancePrivateServiceExample Please fix these to complete your PR |
1 similar comment
Tests failed during RECORDING mode: TestAccRedisInstance_redisInstancePrivateServiceExample Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…gleCloudPlatform#8520) Signed-off-by: Modular Magician <magic-modules@google.com>
Added resource
google_dataproc_metastore_service
resolves hashicorp/terraform-provider-google#8034
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)