Add MTU to interconnect

[upodroid]

Fixes: hashicorp/terraform-provider-google#8227

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `mtu` field to `google_compute_interconnect_attachment`

[upodroid]

This has no test but the MTU field is updatable. I created a partner interconnect with 1500 and set it to 1440 by patching it using the API Explorer :(

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 35 insertions(+))
Terraform Beta: Diff ( 2 files changed, 35 insertions(+))
Ansible: Diff ( 2 files changed, 24 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

[melinath]

It sounds like this field should be marked as default_from_api: true - what do you think?

it looks like there are not currently any tests for this resource. Do you happen to know if there's a particular reason this resource is hard to write tests for?

[upodroid]

I'm not sure.

Creating dedicated interconnects requires paperwork with Google.

hashicorp/terraform-provider-google#7972 @rileykarson may know the full details.

[rileykarson]

It was previously impossible for us to provision one, but it should actually work now since our CI project has been added to a list of projects that provision fake interconnects.

[melinath]

I'll open a new issue for us to add interconnect tests. However, this seems like it should use default_from_api - @upodroid please let me know if that seems incorrect.

[upodroid]

Ok, i'll push a change

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 36 insertions(+))
Terraform Beta: Diff ( 3 files changed, 37 insertions(+), 1 deletion(-))
Ansible: Diff ( 2 files changed, 24 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

[melinath]

/gcbrun

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=174599"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 36 insertions(+))
Terraform Beta: Diff ( 2 files changed, 36 insertions(+))
Ansible: Diff ( 2 files changed, 24 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_update|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionAutoscaler_scaleInControl|TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=174601"

[melinath]

LGTM