Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tag value resource #4603

Merged
merged 5 commits into from
Mar 30, 2021

Conversation

melinath
Copy link
Member

@melinath melinath commented Mar 17, 2021

Related to hashicorp/terraform-provider-google#8428. Added support for tag values. API documentation: https://cloud.google.com/resource-manager/reference/rest/v3/tagValues

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_tags_tag_value`

@google-cla google-cla bot added the cla: yes label Mar 17, 2021
@melinath melinath force-pushed the tpg-8428-tag-value branch from 617981c to 2a9e92c Compare March 18, 2021 17:06
@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@melinath melinath force-pushed the tpg-8428-tag-value branch from ff43127 to 1be62ba Compare March 18, 2021 21:05
@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 122 insertions(+))
Terraform Beta: Diff ( 6 files changed, 803 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177953"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccAccessContextManager|TestAccNotebooksInstance_notebookInstanceFullExample|TestAccTags You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177958"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccNotebooksInstance_notebookInstanceFullExample Please fix these to complete your PR

@melinath melinath requested review from a team and ScottSuarez and removed request for a team March 19, 2021 16:49
@melinath melinath requested review from c2thorn and removed request for ScottSuarez March 24, 2021 18:45
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took me a while to get to.

mmv1/products/tags/api.yaml Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 122 insertions(+))
Terraform Beta: Diff ( 10 files changed, 970 insertions(+), 165 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179735"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccNotebooksInstance_notebookInstanceFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179751"

@melinath
Copy link
Member Author

Failing test is unrelated.

@melinath melinath merged commit b029983 into GoogleCloudPlatform:master Mar 30, 2021
@melinath melinath deleted the tpg-8428-tag-value branch March 30, 2021 17:48
@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccNotebooksInstance_notebookInstanceFullExample Please fix these to complete your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants