Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schemaSettings support to PubSub topic #4713

Conversation

Gabesz-Papp
Copy link
Contributor

Add schemaSettings to Pub/Sub topic resource.

Reference: https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.topics/create

Contributes to (part of): hashicorp/terraform-provider-google#8677

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

pubsub: Added `schema_settings` support to `google-pubsub-topic`

@google-cla google-cla bot added the cla: yes label Apr 20, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 123 insertions(+))
Terraform Beta: Diff ( 3 files changed, 124 insertions(+), 1 deletion(-))
Ansible: Diff ( 2 files changed, 78 insertions(+))
TF Conversion: Diff ( 1 file changed, 40 insertions(+))
Inspec: Diff ( 5 files changed, 53 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183234"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 178 insertions(+))
Terraform Beta: Diff ( 4 files changed, 179 insertions(+), 1 deletion(-))
Ansible: Diff ( 2 files changed, 78 insertions(+))
TF Conversion: Diff ( 1 file changed, 40 insertions(+))
TF OiCS: Diff ( 4 files changed, 109 insertions(+))
Inspec: Diff ( 5 files changed, 53 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183425"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccComputeBackendService_internalLoadBalancing|TestAccPubsubTopic_pubsubTopicSchemaSettingsExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183427"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccPubsubTopic_pubsubTopicSchemaSettingsExample|TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR

resource "google_pubsub_topic" "<%= ctx[:primary_resource_id] %>" {
name = "<%= ctx[:vars]['topic_name'] %>"

schema_settings {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our CI is getting the following error with this example:

Error: Error creating Topic: googleapi: Error 400: Schema settings for the topic <topic-name-here> must include both the name and the encoding.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I included this change in the following PR: #4741 because for topic creation with schema in test the schema creation is needed as well. This PR can be closed

@cagataygurturk
Copy link
Contributor

Hi, I believe there is an issue with this new feature. schema_settings on a topic is immutable and when they are updated, it triggers an in-place update that fails with the following message:

Invalid update_mask provided in the UpdateTopicRequest: the 'schema_settings' field in the Topic is not mutable.

Could you confirm that this finding is true, so we can create an issue?

@c2thorn
Copy link
Member

c2thorn commented Aug 16, 2021

Hi, I believe there is an issue with this new feature. schema_settings on a topic is immutable and when they are updated, it triggers an in-place update that fails with the following message:

Invalid update_mask provided in the UpdateTopicRequest: the 'schema_settings' field in the Topic is not mutable.

Could you confirm that this finding is true, so we can create an issue?

This PR was never merged and shouldn't be related to this issue. If you are experiencing issues I would go ahead and create an issue describing your findings, provider versions, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants