-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schemaSettings support to PubSub topic #4713
Add schemaSettings support to PubSub topic #4713
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 123 insertions(+)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183234" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 178 insertions(+)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183425" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccComputeBackendService_internalLoadBalancing|TestAccPubsubTopic_pubsubTopicSchemaSettingsExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183427" |
Tests failed during RECORDING mode: TestAccPubsubTopic_pubsubTopicSchemaSettingsExample|TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR |
resource "google_pubsub_topic" "<%= ctx[:primary_resource_id] %>" { | ||
name = "<%= ctx[:vars]['topic_name'] %>" | ||
|
||
schema_settings { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our CI is getting the following error with this example:
Error: Error creating Topic: googleapi: Error 400: Schema settings for the topic <topic-name-here> must include both the name and the encoding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I included this change in the following PR: #4741 because for topic creation with schema in test the schema creation is needed as well. This PR can be closed
Hi, I believe there is an issue with this new feature. schema_settings on a topic is immutable and when they are updated, it triggers an in-place update that fails with the following message:
Could you confirm that this finding is true, so we can create an issue? |
This PR was never merged and shouldn't be related to this issue. If you are experiencing issues I would go ahead and create an issue describing your findings, provider versions, etc. |
Add
schemaSettings
to Pub/Sub topic resource.Reference: https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.topics/create
Contributes to (part of): hashicorp/terraform-provider-google#8677
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)