Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Instance schedules to Google compute resource policy #4779

Merged
merged 2 commits into from
May 18, 2021

Conversation

JanMa
Copy link
Contributor

@JanMa JanMa commented May 12, 2021

This PR adds support for instance_schedule_policy to the google_compute_resource_policy resource. It also adds a missing description field.

Closes hashicorp/terraform-provider-google#9001

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added "instance_schedule_policy" field to "google_compute_resource_policy" resource
compute: added "description" field to "google_compute_resource_policy" resource

@google-cla google-cla bot added the cla: yes label May 12, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@JanMa JanMa changed the title Instance schedule Add support for Instance schedules to Google compute resource policy May 12, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 388 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 388 insertions(+), 2 deletions(-))
Ansible: Diff ( 2 files changed, 227 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 121 insertions(+))
TF OiCS: Diff ( 4 files changed, 115 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187005"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeResourcePolicy_resourcePolicyInstanceSchedulePolicyExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187006"

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! No update for this resource so no complications there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for instanceSchedulePolicy
3 participants