Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial transfer of bigqueryreservation assignment into tpgtools #4807

Conversation

melinath
Copy link
Member

@melinath melinath commented May 21, 2021

Related to hashicorp/terraform-provider-google#6694

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_bigquery_reservation_assignment`

@google-cla google-cla bot added the cla: yes label May 21, 2021
@melinath melinath changed the title Initial transfer of bigqueryreservation into tpgtools Initial transfer of bigqueryreservation assignment into tpgtools May 21, 2021
@melinath melinath force-pushed the tpg-6694-bigquery-reservation-assignment branch from f9a8493 to b424b55 Compare May 21, 2021 20:11
@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@melinath melinath force-pushed the tpg-6694-bigquery-reservation-assignment branch from b424b55 to 5f40c2e Compare July 21, 2021 17:59
@modular-magician

This comment has been minimized.

@melinath melinath force-pushed the tpg-6694-bigquery-reservation-assignment branch from 5f40c2e to 34fa827 Compare July 21, 2021 18:06
@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@melinath melinath force-pushed the tpg-6694-bigquery-reservation-assignment branch 2 times, most recently from 24d6067 to 5e0bbd9 Compare July 21, 2021 21:42
@modular-magician

This comment has been minimized.

@melinath melinath force-pushed the tpg-6694-bigquery-reservation-assignment branch from 5e0bbd9 to f905b93 Compare July 21, 2021 22:29
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 413 insertions(+))
Terraform Beta: Diff ( 5 files changed, 413 insertions(+))

@melinath melinath force-pushed the tpg-6694-bigquery-reservation-assignment branch from f905b93 to 52f39cf Compare July 29, 2021 14:27
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 423 insertions(+))
Terraform Beta: Diff ( 7 files changed, 424 insertions(+), 2 deletions(-))

@melinath melinath force-pushed the tpg-6694-bigquery-reservation-assignment branch from 52f39cf to d4875d6 Compare August 25, 2021 19:00
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 444 insertions(+))
Terraform Beta: Diff ( 6 files changed, 444 insertions(+))

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

4 similar comments
@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 444 insertions(+))
Terraform Beta: Diff ( 7 files changed, 445 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentBasic|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=202837

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentBasic Please fix these to complete your PR

@melinath melinath force-pushed the tpg-6694-bigquery-reservation-assignment branch from 6ae6815 to f6eb800 Compare August 31, 2021 21:35
@melinath
Copy link
Member Author

Where this is currently at:

  • it's able to create but not delete resources, because the id getting stored is wrong.
  • We probably need to start using DCL resource ID() across the board in order for this to work properly.
  • There is also probably going to still be a permadiff due to location not being set on the resource - maybe we need to extract all the fields from the dcl resource?

@melinath
Copy link
Member Author

melinath commented Jan 6, 2022

This was done elsewhere

@melinath melinath closed this Jan 6, 2022
@melinath melinath deleted the tpg-6694-bigquery-reservation-assignment branch January 6, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants