Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserProjectOverride for ContainerOperationWaiter #4874

Merged
merged 2 commits into from
Jun 15, 2021
Merged

UserProjectOverride for ContainerOperationWaiter #4874

merged 2 commits into from
Jun 15, 2021

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented Jun 15, 2021 •
edited
Loading

Add UserProjectOverride support to ContainerOperationWaiter.

Fixes hashicorp/terraform-provider-google#9368

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: Added `user_project_override` support to the ContainerOperationWaiter used by `google_container_cluster`

@google-cla google-cla bot added the cla: yes label Jun 15, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 17 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 2 files changed, 18 insertions(+), 12 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192122"

@karlkfi
Copy link
Contributor Author

karlkfi commented Jun 15, 2021

Build

$ bundle exec compiler -a -v "ga" -e terraform -o "$(go env GOPATH)/src/github.com/hashicorp/terraform-provider-google"
I, [2021-06-15T01:13:32.888823 #1975406]  INFO -- : Generating MM output to '/home/karlisenberg/go/src/github.com/hashicorp/terraform-provider-google'
I, [2021-06-15T01:13:32.888874 #1975406]  INFO -- : Using ga version
I, [2021-06-15T01:13:32.905714 #1975406]  INFO -- : products/apigateway does not have a 'ga' version, skipping
I, [2021-06-15T01:13:32.962223 #1975406]  INFO -- : products/apigee: Compiling provider config
I, [2021-06-15T01:13:33.125651 #1975406]  INFO -- : products/apigee: Generating types: ALL
I, [2021-06-15T01:13:33.125704 #1975406]  INFO -- : Generating Organization
I, [2021-06-15T01:13:34.455836 #1975406]  INFO -- : Generating Instance
I, [2021-06-15T01:13:35.754508 #1975406]  INFO -- : Generating Environment
I, [2021-06-15T01:13:37.025461 #1975406]  INFO -- : Generating Envgroup
I, [2021-06-15T01:13:38.280725 #1975406]  INFO -- : Generating InstanceAttachment
I, [2021-06-15T01:13:39.564625 #1975406]  INFO -- : Generating EnvgroupAttachment
I, [2021-06-15T01:13:40.717995 #1975406]  INFO -- : products/bigqueryreservation: Compiling provider config
I, [2021-06-15T01:13:40.833579 #1975406]  INFO -- : products/bigqueryreservation: Generating types: ALL
I, [2021-06-15T01:13:40.833643 #1975406]  INFO -- : Generating Reservation
I, [2021-06-15T01:13:42.115043 #1975406]  INFO -- : products/iambeta does not have a 'ga' version, skipping
I, [2021-06-15T01:13:42.156308 #1975406]  INFO -- : products/secretmanager: Compiling provider config
I, [2021-06-15T01:13:42.272424 #1975406]  INFO -- : products/secretmanager: Generating types: ALL
I, [2021-06-15T01:13:42.272471 #1975406]  INFO -- : Generating Secret
I, [2021-06-15T01:13:43.608021 #1975406]  INFO -- : Generating SecretVersion
I, [2021-06-15T01:13:44.535337 #1975406]  INFO -- : products/redis: Compiling provider config
I, [2021-06-15T01:13:44.652331 #1975406]  INFO -- : products/redis: Generating types: ALL
I, [2021-06-15T01:13:44.652379 #1975406]  INFO -- : Generating Instance
I, [2021-06-15T01:13:46.357347 #1975406]  INFO -- : products/serviceusage: Compiling provider config
I, [2021-06-15T01:13:46.474086 #1975406]  INFO -- : products/serviceusage: Generating types: ALL
I, [2021-06-15T01:13:46.474135 #1975406]  INFO -- : Excluding AdminQuotaOverride per API catalog
I, [2021-06-15T01:13:46.474157 #1975406]  INFO -- : Excluding ConsumerQuotaOverride per API version
I, [2021-06-15T01:13:46.474169 #1975406]  INFO -- : Excluding Service per API catalog
I, [2021-06-15T01:13:46.861187 #1975406]  INFO -- : products/kms: Compiling provider config
I, [2021-06-15T01:13:46.981562 #1975406]  INFO -- : products/kms: Generating types: ALL
I, [2021-06-15T01:13:46.981610 #1975406]  INFO -- : Generating KeyRing
I, [2021-06-15T01:13:47.337635 #1975406]  INFO -- : Generating CryptoKey
I, [2021-06-15T01:13:47.725356 #1975406]  INFO -- : Generating KeyRingImportJob
I, [2021-06-15T01:13:48.618622 #1975406]  INFO -- : Generating SecretCiphertext
I, [2021-06-15T01:13:48.974021 #1975406]  INFO -- : products/container: Skipped as no terraform.yaml file exists
I, [2021-06-15T01:13:49.107388 #1975406]  INFO -- : products/datacatalog: Compiling provider config
I, [2021-06-15T01:13:49.223457 #1975406]  INFO -- : products/datacatalog: Generating types: ALL
I, [2021-06-15T01:13:49.223504 #1975406]  INFO -- : Generating EntryGroup
I, [2021-06-15T01:13:50.525136 #1975406]  INFO -- : Generating Entry
I, [2021-06-15T01:13:51.918585 #1975406]  INFO -- : Generating TagTemplate
I, [2021-06-15T01:13:52.825344 #1975406]  INFO -- : Generating Tag
I, [2021-06-15T01:13:54.185809 #1975406]  INFO -- : Excluding Taxonomy per API version
I, [2021-06-15T01:13:54.185849 #1975406]  INFO -- : Excluding PolicyTag per API version
I, [2021-06-15T01:13:54.545547 #1975406]  INFO -- : products/cloudrun: Compiling provider config
I, [2021-06-15T01:13:54.664516 #1975406]  INFO -- : products/cloudrun: Generating types: ALL
I, [2021-06-15T01:13:54.664564 #1975406]  INFO -- : Generating DomainMapping
I, [2021-06-15T01:13:56.052616 #1975406]  INFO -- : Generating Service
I, [2021-06-15T01:13:57.728171 #1975406]  INFO -- : products/resourcemanager: Compiling provider config
I, [2021-06-15T01:13:57.846756 #1975406]  INFO -- : products/resourcemanager: Generating types: ALL
I, [2021-06-15T01:13:57.846801 #1975406]  INFO -- : Excluding Project per API catalog
I, [2021-06-15T01:13:57.846819 #1975406]  INFO -- : Generating Lien
I, [2021-06-15T01:13:58.227092 #1975406]  INFO -- : Excluding Folder per API catalog
I, [2021-06-15T01:13:58.227120 #1975406]  INFO -- : Excluding Organization per API catalog
I, [2021-06-15T01:13:58.579136 #1975406]  INFO -- : products/datastore: Compiling provider config
I, [2021-06-15T01:13:58.697915 #1975406]  INFO -- : products/datastore: Generating types: ALL
I, [2021-06-15T01:13:58.697963 #1975406]  INFO -- : Generating Index
I, [2021-06-15T01:13:59.906627 #1975406]  INFO -- : products/bigqueryconnection does not have a 'ga' version, skipping
I, [2021-06-15T01:13:59.937463 #1975406]  INFO -- : products/deploymentmanager: Compiling provider config
I, [2021-06-15T01:14:00.058083 #1975406]  INFO -- : products/deploymentmanager: Generating types: ALL
I, [2021-06-15T01:14:00.058138 #1975406]  INFO -- : Generating Deployment
I, [2021-06-15T01:14:01.024563 #1975406]  INFO -- : products/identityplatform: Compiling provider config
I, [2021-06-15T01:14:01.147431 #1975406]  INFO -- : products/identityplatform: Generating types: ALL
I, [2021-06-15T01:14:01.147480 #1975406]  INFO -- : Generating DefaultSupportedIdpConfig
I, [2021-06-15T01:14:01.977545 #1975406]  INFO -- : Generating TenantDefaultSupportedIdpConfig
I, [2021-06-15T01:14:02.833771 #1975406]  INFO -- : Generating InboundSamlConfig
I, [2021-06-15T01:14:04.189075 #1975406]  INFO -- : Generating TenantInboundSamlConfig
I, [2021-06-15T01:14:05.534944 #1975406]  INFO -- : Generating OauthIdpConfig
I, [2021-06-15T01:14:06.827780 #1975406]  INFO -- : Generating TenantOauthIdpConfig
I, [2021-06-15T01:14:08.118024 #1975406]  INFO -- : Generating Tenant
I, [2021-06-15T01:14:09.437586 #1975406]  INFO -- : products/pubsublite: Compiling provider config
I, [2021-06-15T01:14:09.553524 #1975406]  INFO -- : products/pubsublite: Generating types: ALL
I, [2021-06-15T01:14:09.553573 #1975406]  INFO -- : Generating Topic
I, [2021-06-15T01:14:10.858907 #1975406]  INFO -- : Generating Subscription
I, [2021-06-15T01:14:12.182055 #1975406]  INFO -- : products/networkmanagement: Compiling provider config
I, [2021-06-15T01:14:12.302505 #1975406]  INFO -- : products/networkmanagement: Generating types: ALL
I, [2021-06-15T01:14:12.302554 #1975406]  INFO -- : Generating ConnectivityTest
I, [2021-06-15T01:14:14.106981 #1975406]  INFO -- : products/dataproc: Compiling provider config
I, [2021-06-15T01:14:14.224809 #1975406]  INFO -- : products/dataproc: Generating types: ALL
I, [2021-06-15T01:14:14.224859 #1975406]  INFO -- : Generating AutoscalingPolicy
I, [2021-06-15T01:14:15.596961 #1975406]  INFO -- : Excluding Cluster per API catalog
I, [2021-06-15T01:14:25.386189 #1975406]  INFO -- : products/compute: Compiling provider config
I, [2021-06-15T01:14:25.503713 #1975406]  INFO -- : products/compute: Generating types: ALL
I, [2021-06-15T01:14:25.503767 #1975406]  INFO -- : Generating Address
I, [2021-06-15T01:14:26.832831 #1975406]  INFO -- : Generating Autoscaler
I, [2021-06-15T01:14:28.267031 #1975406]  INFO -- : Generating BackendBucket
I, [2021-06-15T01:14:29.576756 #1975406]  INFO -- : Generating BackendBucketSignedUrlKey
I, [2021-06-15T01:14:30.410419 #1975406]  INFO -- : Generating BackendService
I, [2021-06-15T01:14:39.975405 #1975406]  INFO -- : Generating RegionBackendService
I, [2021-06-15T01:14:41.715731 #1975406]  INFO -- : Generating BackendServiceSignedUrlKey
I, [2021-06-15T01:14:42.540538 #1975406]  INFO -- : Excluding DiskType per API catalog
I, [2021-06-15T01:14:42.540583 #1975406]  INFO -- : Generating RegionDiskResourcePolicyAttachment
I, [2021-06-15T01:14:43.374316 #1975406]  INFO -- : Generating DiskResourcePolicyAttachment
I, [2021-06-15T01:14:44.205993 #1975406]  INFO -- : Generating Disk
I, [2021-06-15T01:14:45.304596 #1975406]  INFO -- : Generating Firewall
I, [2021-06-15T01:14:46.725886 #1975406]  INFO -- : Generating ForwardingRule
I, [2021-06-15T01:14:48.119821 #1975406]  INFO -- : Generating GlobalAddress
I, [2021-06-15T01:14:49.449445 #1975406]  INFO -- : Generating GlobalForwardingRule
I, [2021-06-15T01:14:50.872750 #1975406]  INFO -- : Generating HttpHealthCheck
I, [2021-06-15T01:14:52.213187 #1975406]  INFO -- : Generating HttpsHealthCheck
I, [2021-06-15T01:14:53.531085 #1975406]  INFO -- : Generating HealthCheck
I, [2021-06-15T01:14:55.115674 #1975406]  INFO -- : Excluding InstanceTemplate per API catalog
I, [2021-06-15T01:14:55.115710 #1975406]  INFO -- : Excluding License per API catalog
I, [2021-06-15T01:14:55.115727 #1975406]  INFO -- : Generating Image
I, [2021-06-15T01:14:56.598735 #1975406]  INFO -- : Generating Instance
I, [2021-06-15T01:14:56.628912 #1975406]  INFO -- : Excluding InstanceGroup per API catalog
I, [2021-06-15T01:14:56.628938 #1975406]  INFO -- : Excluding InstanceGroupManager per API catalog
I, [2021-06-15T01:14:56.628965 #1975406]  INFO -- : Generating InstanceGroupNamedPort
I, [2021-06-15T01:14:57.902392 #1975406]  INFO -- : Excluding RegionInstanceGroupManager per API catalog
I, [2021-06-15T01:14:57.902443 #1975406]  INFO -- : Generating InterconnectAttachment
I, [2021-06-15T01:14:58.821482 #1975406]  INFO -- : Excluding MachineImage per API version
I, [2021-06-15T01:14:58.821517 #1975406]  INFO -- : Excluding MachineType per API catalog
I, [2021-06-15T01:14:58.821531 #1975406]  INFO -- : Generating Network
I, [2021-06-15T01:15:00.109861 #1975406]  INFO -- : Generating NetworkEndpoint
I, [2021-06-15T01:15:00.482015 #1975406]  INFO -- : Generating NetworkEndpointGroup
I, [2021-06-15T01:15:01.781470 #1975406]  INFO -- : Generating GlobalNetworkEndpoint
I, [2021-06-15T01:15:02.155303 #1975406]  INFO -- : Generating GlobalNetworkEndpointGroup
I, [2021-06-15T01:15:03.446381 #1975406]  INFO -- : Generating RegionNetworkEndpointGroup
I, [2021-06-15T01:15:04.787917 #1975406]  INFO -- : Generating NodeGroup
I, [2021-06-15T01:15:06.136409 #1975406]  INFO -- : Generating NetworkPeeringRoutesConfig
I, [2021-06-15T01:15:06.514893 #1975406]  INFO -- : Generating NodeTemplate
I, [2021-06-15T01:15:07.845862 #1975406]  INFO -- : Excluding OrganizationSecurityPolicy per API version
I, [2021-06-15T01:15:07.845900 #1975406]  INFO -- : Excluding OrganizationSecurityPolicyAssociation per API version
I, [2021-06-15T01:15:07.845913 #1975406]  INFO -- : Excluding OrganizationSecurityPolicyRule per API version
I, [2021-06-15T01:15:07.845925 #1975406]  INFO -- : Generating PacketMirroring
I, [2021-06-15T01:15:09.215282 #1975406]  INFO -- : Generating PerInstanceConfig
I, [2021-06-15T01:15:09.606176 #1975406]  INFO -- : Generating RegionPerInstanceConfig
I, [2021-06-15T01:15:09.999950 #1975406]  INFO -- : Excluding ProjectInfo per API catalog
I, [2021-06-15T01:15:09.999986 #1975406]  INFO -- : Excluding Region per API catalog
I, [2021-06-15T01:15:10.000002 #1975406]  INFO -- : Generating RegionAutoscaler
I, [2021-06-15T01:15:11.416461 #1975406]  INFO -- : Excluding RegionDiskType per API catalog
I, [2021-06-15T01:15:11.416512 #1975406]  INFO -- : Generating RegionDisk
I, [2021-06-15T01:15:12.366310 #1975406]  INFO -- : Generating RegionUrlMap
I, [2021-06-15T01:15:14.690260 #1975406]  INFO -- : Generating RegionHealthCheck
I, [2021-06-15T01:15:16.281965 #1975406]  INFO -- : Generating ResourcePolicy
I, [2021-06-15T01:15:17.731847 #1975406]  INFO -- : Generating Route
I, [2021-06-15T01:15:19.057391 #1975406]  INFO -- : Generating Router
I, [2021-06-15T01:15:20.399845 #1975406]  INFO -- : Generating RouterNat
I, [2021-06-15T01:15:21.320956 #1975406]  INFO -- : Generating RouterBgpPeer
I, [2021-06-15T01:15:22.194545 #1975406]  INFO -- : Excluding SecurityPolicy per API catalog
I, [2021-06-15T01:15:22.194593 #1975406]  INFO -- : Generating Snapshot
I, [2021-06-15T01:15:23.565885 #1975406]  INFO -- : Generating SslCertificate
I, [2021-06-15T01:15:24.864156 #1975406]  INFO -- : Generating ManagedSslCertificate
I, [2021-06-15T01:15:26.170643 #1975406]  INFO -- : Generating RegionSslCertificate
I, [2021-06-15T01:15:27.465808 #1975406]  INFO -- : Generating Reservation
I, [2021-06-15T01:15:28.851366 #1975406]  INFO -- : Excluding ServiceAttachment per API version
I, [2021-06-15T01:15:28.851408 #1975406]  INFO -- : Generating SslPolicy
I, [2021-06-15T01:15:30.156768 #1975406]  INFO -- : Generating Subnetwork
I, [2021-06-15T01:15:32.273778 #1975406]  INFO -- : Generating TargetHttpProxy
I, [2021-06-15T01:15:33.560818 #1975406]  INFO -- : Generating TargetHttpsProxy
I, [2021-06-15T01:15:34.873581 #1975406]  INFO -- : Generating RegionTargetHttpProxy
I, [2021-06-15T01:15:36.175471 #1975406]  INFO -- : Generating RegionTargetHttpsProxy
I, [2021-06-15T01:15:37.477600 #1975406]  INFO -- : Generating TargetInstance
I, [2021-06-15T01:15:38.770526 #1975406]  INFO -- : Excluding TargetPool per API catalog
I, [2021-06-15T01:15:38.770568 #1975406]  INFO -- : Generating TargetSslProxy
I, [2021-06-15T01:15:40.075377 #1975406]  INFO -- : Generating TargetTcpProxy
I, [2021-06-15T01:15:41.390395 #1975406]  INFO -- : Generating VpnGateway
I, [2021-06-15T01:15:42.715005 #1975406]  INFO -- : Generating HaVpnGateway
I, [2021-06-15T01:15:44.052520 #1975406]  INFO -- : Generating ExternalVpnGateway
I, [2021-06-15T01:15:45.365653 #1975406]  INFO -- : Generating UrlMap
I, [2021-06-15T01:15:48.353910 #1975406]  INFO -- : Generating VpnTunnel
I, [2021-06-15T01:15:49.714676 #1975406]  INFO -- : Excluding Zone per API catalog
I, [2021-06-15T01:15:49.714720 #1975406]  INFO -- : Generating TargetGrpcProxy
I, [2021-06-15T01:15:51.030056 #1975406]  INFO -- : products/iam: Skipped as no terraform.yaml file exists
I, [2021-06-15T01:15:51.053542 #1975406]  INFO -- : products/datafusion does not have a 'ga' version, skipping
I, [2021-06-15T01:15:51.107528 #1975406]  INFO -- : products/cloudtasks: Compiling provider config
I, [2021-06-15T01:15:51.225273 #1975406]  INFO -- : products/cloudtasks: Generating types: ALL
I, [2021-06-15T01:15:51.225320 #1975406]  INFO -- : Generating Queue
I, [2021-06-15T01:15:52.729192 #1975406]  INFO -- : products/cloudasset: Compiling provider config
I, [2021-06-15T01:15:52.853742 #1975406]  INFO -- : products/cloudasset: Generating types: ALL
I, [2021-06-15T01:15:52.853791 #1975406]  INFO -- : Generating ProjectFeed
I, [2021-06-15T01:15:54.200300 #1975406]  INFO -- : Generating FolderFeed
I, [2021-06-15T01:15:55.537477 #1975406]  INFO -- : Generating OrganizationFeed
I, [2021-06-15T01:15:56.919895 #1975406]  INFO -- : products/activedirectory: Compiling provider config
I, [2021-06-15T01:15:57.037671 #1975406]  INFO -- : products/activedirectory: Generating types: ALL
I, [2021-06-15T01:15:57.037718 #1975406]  INFO -- : Generating Domain
I, [2021-06-15T01:15:58.339524 #1975406]  INFO -- : Generating DomainTrust
I, [2021-06-15T01:15:59.068986 #1975406]  INFO -- : products/essentialcontacts does not have a 'ga' version, skipping
I, [2021-06-15T01:15:59.109710 #1975406]  INFO -- : products/bigtable: Compiling provider config
I, [2021-06-15T01:15:59.225323 #1975406]  INFO -- : products/bigtable: Generating types: ALL
I, [2021-06-15T01:15:59.225372 #1975406]  INFO -- : Generating AppProfile
I, [2021-06-15T01:16:00.711201 #1975406]  INFO -- : Excluding Instance per API catalog
I, [2021-06-15T01:16:01.250055 #1975406]  INFO -- : products/dlp: Compiling provider config
I, [2021-06-15T01:16:01.368452 #1975406]  INFO -- : products/dlp: Generating types: ALL
I, [2021-06-15T01:16:01.368502 #1975406]  INFO -- : Generating JobTrigger
I, [2021-06-15T01:16:02.927350 #1975406]  INFO -- : Generating InspectTemplate
I, [2021-06-15T01:16:04.543279 #1975406]  INFO -- : Generating StoredInfoType
I, [2021-06-15T01:16:05.964291 #1975406]  INFO -- : Generating DeidentifyTemplate
I, [2021-06-15T01:16:07.561114 #1975406]  INFO -- : products/cloudiot: Compiling provider config
I, [2021-06-15T01:16:07.676381 #1975406]  INFO -- : products/cloudiot: Generating types: ALL
I, [2021-06-15T01:16:07.676428 #1975406]  INFO -- : Generating DeviceRegistry
I, [2021-06-15T01:16:08.981433 #1975406]  INFO -- : Generating Device
I, [2021-06-15T01:16:10.566363 #1975406]  INFO -- : products/logging: Compiling provider config
I, [2021-06-15T01:16:10.685339 #1975406]  INFO -- : products/logging: Generating types: ALL
I, [2021-06-15T01:16:10.685388 #1975406]  INFO -- : Generating Metric
I, [2021-06-15T01:16:12.080549 #1975406]  INFO -- : Excluding OrganizationLogSink per API catalog
I, [2021-06-15T01:16:12.080584 #1975406]  INFO -- : Excluding ProjectLogSink per API catalog
I, [2021-06-15T01:16:12.080595 #1975406]  INFO -- : Excluding FolderExclusion per API catalog
I, [2021-06-15T01:16:12.080603 #1975406]  INFO -- : Excluding ProjectExclusion per API catalog
I, [2021-06-15T01:16:12.080610 #1975406]  INFO -- : Excluding FolderLogSink per API catalog
I, [2021-06-15T01:16:12.108028 #1975406]  INFO -- : products/metastore does not have a 'ga' version, skipping
I, [2021-06-15T01:16:12.136811 #1975406]  INFO -- : products/runtimeconfig: Compiling provider config
I, [2021-06-15T01:16:12.260189 #1975406]  INFO -- : products/runtimeconfig: Generating types: ALL
I, [2021-06-15T01:16:12.260237 #1975406]  INFO -- : Generating Config
I, [2021-06-15T01:16:12.288228 #1975406]  INFO -- : Excluding Variable per API catalog
I, [2021-06-15T01:16:13.038643 #1975406]  INFO -- : products/bigquery: Compiling provider config
I, [2021-06-15T01:16:13.156763 #1975406]  INFO -- : products/bigquery: Generating types: ALL
I, [2021-06-15T01:16:13.156829 #1975406]  INFO -- : Generating Dataset
I, [2021-06-15T01:16:14.103812 #1975406]  INFO -- : Generating DatasetAccess
I, [2021-06-15T01:16:14.520579 #1975406]  INFO -- : Generating Job
I, [2021-06-15T01:16:15.435234 #1975406]  INFO -- : Generating Table
I, [2021-06-15T01:16:15.467846 #1975406]  INFO -- : Generating Routine
I, [2021-06-15T01:16:16.863987 #1975406]  INFO -- : products/workflows: Compiling provider config
I, [2021-06-15T01:16:16.982416 #1975406]  INFO -- : products/workflows: Generating types: ALL
I, [2021-06-15T01:16:16.982463 #1975406]  INFO -- : Generating Workflow
I, [2021-06-15T01:16:18.677793 #1975406]  INFO -- : products/spanner: Compiling provider config
I, [2021-06-15T01:16:18.796736 #1975406]  INFO -- : products/spanner: Generating types: ALL
I, [2021-06-15T01:16:18.796779 #1975406]  INFO -- : Excluding InstanceConfig per API catalog
I, [2021-06-15T01:16:18.796796 #1975406]  INFO -- : Generating Instance
I, [2021-06-15T01:16:19.637244 #1975406]  INFO -- : Generating Database
I, [2021-06-15T01:16:20.870845 #1975406]  INFO -- : products/iap: Compiling provider config
I, [2021-06-15T01:16:20.993291 #1975406]  INFO -- : products/iap: Generating types: ALL
I, [2021-06-15T01:16:20.993341 #1975406]  INFO -- : Generating Web
I, [2021-06-15T01:16:21.021928 #1975406]  INFO -- : Generating WebTypeCompute
I, [2021-06-15T01:16:21.050895 #1975406]  INFO -- : Generating WebTypeAppEngine
I, [2021-06-15T01:16:21.082190 #1975406]  INFO -- : Generating AppEngineVersion
I, [2021-06-15T01:16:21.111008 #1975406]  INFO -- : Generating AppEngineService
I, [2021-06-15T01:16:21.140081 #1975406]  INFO -- : Generating WebBackendService
I, [2021-06-15T01:16:21.170676 #1975406]  INFO -- : Generating TunnelInstance
I, [2021-06-15T01:16:21.202652 #1975406]  INFO -- : Generating Tunnel
I, [2021-06-15T01:16:21.231220 #1975406]  INFO -- : Generating Brand
I, [2021-06-15T01:16:21.595920 #1975406]  INFO -- : Generating Client
I, [2021-06-15T01:16:22.463899 #1975406]  INFO -- : products/vpcaccess: Compiling provider config
I, [2021-06-15T01:16:22.582269 #1975406]  INFO -- : products/vpcaccess: Generating types: ALL
I, [2021-06-15T01:16:22.582321 #1975406]  INFO -- : Generating Connector
I, [2021-06-15T01:16:24.297128 #1975406]  INFO -- : products/mlengine: Compiling provider config
I, [2021-06-15T01:16:24.414645 #1975406]  INFO -- : products/mlengine: Generating types: ALL
I, [2021-06-15T01:16:24.414729 #1975406]  INFO -- : Generating Model
I, [2021-06-15T01:16:25.728245 #1975406]  INFO -- : Excluding Version per API catalog
I, [2021-06-15T01:16:26.140718 #1975406]  INFO -- : products/billingbudget: Compiling provider config
I, [2021-06-15T01:16:26.257873 #1975406]  INFO -- : products/billingbudget: Generating types: ALL
I, [2021-06-15T01:16:26.257922 #1975406]  INFO -- : Generating Budget
I, [2021-06-15T01:16:27.716453 #1975406]  INFO -- : products/cloudfunctions: Compiling provider config
I, [2021-06-15T01:16:27.834984 #1975406]  INFO -- : products/cloudfunctions: Generating types: ALL
I, [2021-06-15T01:16:27.835031 #1975406]  INFO -- : Generating CloudFunction
I, [2021-06-15T01:16:28.169288 #1975406]  INFO -- : products/cloudbuild: Compiling provider config
I, [2021-06-15T01:16:28.285942 #1975406]  INFO -- : products/cloudbuild: Generating types: ALL
I, [2021-06-15T01:16:28.285989 #1975406]  INFO -- : Generating Trigger
I, [2021-06-15T01:16:30.094991 #1975406]  INFO -- : products/accessapproval: Compiling provider config
I, [2021-06-15T01:16:30.219564 #1975406]  INFO -- : products/accessapproval: Generating types: ALL
I, [2021-06-15T01:16:30.219613 #1975406]  INFO -- : Generating FolderSettings
I, [2021-06-15T01:16:30.618879 #1975406]  INFO -- : Generating ProjectSettings
I, [2021-06-15T01:16:31.007851 #1975406]  INFO -- : Generating OrganizationSettings
I, [2021-06-15T01:16:31.472384 #1975406]  INFO -- : products/pubsub: Compiling provider config
I, [2021-06-15T01:16:31.588484 #1975406]  INFO -- : products/pubsub: Generating types: ALL
I, [2021-06-15T01:16:31.588534 #1975406]  INFO -- : Generating Topic
I, [2021-06-15T01:16:32.929959 #1975406]  INFO -- : Generating Subscription
I, [2021-06-15T01:16:34.320612 #1975406]  INFO -- : Generating Schema
I, [2021-06-15T01:16:35.633066 #1975406]  INFO -- : products/oslogin: Compiling provider config
I, [2021-06-15T01:16:35.749776 #1975406]  INFO -- : products/oslogin: Generating types: ALL
I, [2021-06-15T01:16:35.749836 #1975406]  INFO -- : Generating SSHPublicKey
I, [2021-06-15T01:16:37.855305 #1975406]  INFO -- : products/osconfig: Compiling provider config
I, [2021-06-15T01:16:37.971528 #1975406]  INFO -- : products/osconfig: Generating types: ALL
I, [2021-06-15T01:16:37.971576 #1975406]  INFO -- : Generating PatchDeployment
I, [2021-06-15T01:16:39.765953 #1975406]  INFO -- : Excluding GuestPolicies per API version
I, [2021-06-15T01:16:40.607941 #1975406]  INFO -- : products/accesscontextmanager: Compiling provider config
I, [2021-06-15T01:16:40.724740 #1975406]  INFO -- : products/accesscontextmanager: Generating types: ALL
I, [2021-06-15T01:16:40.724788 #1975406]  INFO -- : Generating AccessPolicy
I, [2021-06-15T01:16:41.095247 #1975406]  INFO -- : Generating AccessLevel
I, [2021-06-15T01:16:41.598830 #1975406]  INFO -- : Generating AccessLevels
I, [2021-06-15T01:16:42.096615 #1975406]  INFO -- : Generating AccessLevelCondition
I, [2021-06-15T01:16:42.521384 #1975406]  INFO -- : Generating ServicePerimeter
I, [2021-06-15T01:16:43.268063 #1975406]  INFO -- : Generating ServicePerimeters
I, [2021-06-15T01:16:44.021046 #1975406]  INFO -- : Generating ServicePerimeterResource
I, [2021-06-15T01:16:44.381409 #1975406]  INFO -- : Generating GcpUserAccessBinding
I, [2021-06-15T01:16:45.604160 #1975406]  INFO -- : products/cloudidentity: Compiling provider config
I, [2021-06-15T01:16:45.723657 #1975406]  INFO -- : products/cloudidentity: Generating types: ALL
I, [2021-06-15T01:16:45.723716 #1975406]  INFO -- : Generating Group
I, [2021-06-15T01:16:46.578432 #1975406]  INFO -- : Generating GroupMembership
I, [2021-06-15T01:16:47.728463 #1975406]  INFO -- : products/storage: Compiling provider config
I, [2021-06-15T01:16:47.849030 #1975406]  INFO -- : products/storage: Generating types: ALL
I, [2021-06-15T01:16:47.849080 #1975406]  INFO -- : Generating Bucket
I, [2021-06-15T01:16:47.876938 #1975406]  INFO -- : Generating BucketAccessControl
I, [2021-06-15T01:16:48.698731 #1975406]  INFO -- : Generating ObjectAccessControl
I, [2021-06-15T01:16:49.543194 #1975406]  INFO -- : Generating DefaultObjectAccessControl
I, [2021-06-15T01:16:50.386513 #1975406]  INFO -- : Excluding Object per API catalog
I, [2021-06-15T01:16:50.386555 #1975406]  INFO -- : Generating HmacKey
I, [2021-06-15T01:16:51.341043 #1975406]  INFO -- : products/notebooks: Compiling provider config
I, [2021-06-15T01:16:51.461647 #1975406]  INFO -- : products/notebooks: Generating types: ALL
I, [2021-06-15T01:16:51.461703 #1975406]  INFO -- : Generating Environment
I, [2021-06-15T01:16:52.778601 #1975406]  INFO -- : Generating Instance
I, [2021-06-15T01:16:54.276018 #1975406]  INFO -- : Generating Location
I, [2021-06-15T01:16:55.415859 #1975406]  INFO -- : products/cloudbilling: Skipped as no terraform.yaml file exists
I, [2021-06-15T01:16:55.452314 #1975406]  INFO -- : products/securityscanner does not have a 'ga' version, skipping
I, [2021-06-15T01:16:55.470599 #1975406]  INFO -- : products/artifactregistry does not have a 'ga' version, skipping
I, [2021-06-15T01:16:55.613325 #1975406]  INFO -- : products/privateca does not have a 'ga' version, skipping
I, [2021-06-15T01:16:55.656093 #1975406]  INFO -- : products/securitycenter: Compiling provider config
I, [2021-06-15T01:16:55.773307 #1975406]  INFO -- : products/securitycenter: Generating types: ALL
I, [2021-06-15T01:16:55.773357 #1975406]  INFO -- : Generating Source
I, [2021-06-15T01:16:56.218527 #1975406]  INFO -- : products/filestore: Compiling provider config
I, [2021-06-15T01:16:56.332653 #1975406]  INFO -- : products/filestore: Generating types: ALL
I, [2021-06-15T01:16:56.332700 #1975406]  INFO -- : Generating Instance
I, [2021-06-15T01:16:58.135599 #1975406]  INFO -- : products/bigquerydatatransfer: Compiling provider config
I, [2021-06-15T01:16:58.256794 #1975406]  INFO -- : products/bigquerydatatransfer: Generating types: ALL
I, [2021-06-15T01:16:58.256850 #1975406]  INFO -- : Generating Config
I, [2021-06-15T01:16:59.284779 #1975406]  INFO -- : products/healthcare: Compiling provider config
I, [2021-06-15T01:16:59.401542 #1975406]  INFO -- : products/healthcare: Generating types: ALL
I, [2021-06-15T01:16:59.401590 #1975406]  INFO -- : Generating Dataset
I, [2021-06-15T01:17:00.677473 #1975406]  INFO -- : Generating DicomStore
I, [2021-06-15T01:17:01.512517 #1975406]  INFO -- : Generating FhirStore
I, [2021-06-15T01:17:02.414693 #1975406]  INFO -- : Generating Hl7V2Store
I, [2021-06-15T01:17:03.290683 #1975406]  INFO -- : Generating ConsentStore
I, [2021-06-15T01:17:05.239105 #1975406]  INFO -- : products/appengine: Compiling provider config
I, [2021-06-15T01:17:05.356531 #1975406]  INFO -- : products/appengine: Generating types: ALL
I, [2021-06-15T01:17:05.356583 #1975406]  INFO -- : Generating DomainMapping
I, [2021-06-15T01:17:06.684976 #1975406]  INFO -- : Generating FirewallRule
I, [2021-06-15T01:17:07.509783 #1975406]  INFO -- : Excluding Service per API catalog
I, [2021-06-15T01:17:07.509826 #1975406]  INFO -- : Generating StandardAppVersion
I, [2021-06-15T01:17:08.598406 #1975406]  INFO -- : Generating FlexibleAppVersion
I, [2021-06-15T01:17:10.014000 #1975406]  INFO -- : Generating ApplicationUrlDispatchRules
I, [2021-06-15T01:17:10.838039 #1975406]  INFO -- : Generating ServiceSplitTraffic
I, [2021-06-15T01:17:11.291879 #1975406]  INFO -- : products/containeranalysis: Compiling provider config
I, [2021-06-15T01:17:11.412738 #1975406]  INFO -- : products/containeranalysis: Generating types: ALL
I, [2021-06-15T01:17:11.412784 #1975406]  INFO -- : Generating Note
I, [2021-06-15T01:17:12.747022 #1975406]  INFO -- : Generating Occurrence
I, [2021-06-15T01:17:13.758194 #1975406]  INFO -- : products/sql: Compiling provider config
I, [2021-06-15T01:17:13.876818 #1975406]  INFO -- : products/sql: Generating types: ALL
I, [2021-06-15T01:17:13.876859 #1975406]  INFO -- : Excluding Instance per API catalog
I, [2021-06-15T01:17:13.876877 #1975406]  INFO -- : Generating Database
I, [2021-06-15T01:17:14.701512 #1975406]  INFO -- : Excluding User per API catalog
I, [2021-06-15T01:17:14.701547 #1975406]  INFO -- : Excluding SslCert per API catalog
I, [2021-06-15T01:17:14.701561 #1975406]  INFO -- : Excluding Flag per API catalog
I, [2021-06-15T01:17:14.701580 #1975406]  INFO -- : Excluding Tier per API catalog
I, [2021-06-15T01:17:14.701598 #1975406]  INFO -- : Generating SourceRepresentationInstance
I, [2021-06-15T01:17:16.069686 #1975406]  INFO -- : products/memcache: Compiling provider config
I, [2021-06-15T01:17:16.186446 #1975406]  INFO -- : products/memcache: Generating types: ALL
I, [2021-06-15T01:17:16.186493 #1975406]  INFO -- : Generating Instance
I, [2021-06-15T01:17:17.911025 #1975406]  INFO -- : products/gkehub does not have a 'ga' version, skipping
I, [2021-06-15T01:17:18.036597 #1975406]  INFO -- : products/gameservices: Compiling provider config
I, [2021-06-15T01:17:18.158949 #1975406]  INFO -- : products/gameservices: Generating types: ALL
I, [2021-06-15T01:17:18.158998 #1975406]  INFO -- : Generating Realm
I, [2021-06-15T01:17:19.481104 #1975406]  INFO -- : Generating GameServerCluster
I, [2021-06-15T01:17:20.847423 #1975406]  INFO -- : Generating GameServerDeployment
I, [2021-06-15T01:17:22.122013 #1975406]  INFO -- : Generating GameServerConfig
I, [2021-06-15T01:17:23.479386 #1975406]  INFO -- : Generating GameServerDeploymentRollout
I, [2021-06-15T01:17:25.187260 #1975406]  INFO -- : products/tags: Compiling provider config
I, [2021-06-15T01:17:25.311503 #1975406]  INFO -- : products/tags: Generating types: ALL
I, [2021-06-15T01:17:25.311553 #1975406]  INFO -- : Generating TagKey
I, [2021-06-15T01:17:26.157948 #1975406]  INFO -- : Generating TagValue
I, [2021-06-15T01:17:27.000451 #1975406]  INFO -- : Generating TagBinding
I, [2021-06-15T01:17:28.199028 #1975406]  INFO -- : products/servicemanagement: Compiling provider config
I, [2021-06-15T01:17:28.317946 #1975406]  INFO -- : products/servicemanagement: Generating types: ALL
I, [2021-06-15T01:17:28.317992 #1975406]  INFO -- : Generating Service
I, [2021-06-15T01:17:28.387340 #1975406]  INFO -- : products/sourcerepo: Compiling provider config
I, [2021-06-15T01:17:28.514528 #1975406]  INFO -- : products/sourcerepo: Generating types: ALL
I, [2021-06-15T01:17:28.514576 #1975406]  INFO -- : Generating Repository
I, [2021-06-15T01:17:30.003901 #1975406]  INFO -- : products/dns: Compiling provider config
I, [2021-06-15T01:17:30.121879 #1975406]  INFO -- : products/dns: Generating types: ALL
I, [2021-06-15T01:17:30.121927 #1975406]  INFO -- : Generating ManagedZone
I, [2021-06-15T01:17:31.716507 #1975406]  INFO -- : Generating Policy
I, [2021-06-15T01:17:32.580325 #1975406]  INFO -- : Excluding Project per API catalog
I, [2021-06-15T01:17:32.580360 #1975406]  INFO -- : Excluding ResourceRecordSet per API catalog
I, [2021-06-15T01:17:32.580377 #1975406]  INFO -- : Generating ResourceDnsRecordSet
I, [2021-06-15T01:17:33.536265 #1975406]  INFO -- : products/cloudscheduler: Compiling provider config
I, [2021-06-15T01:17:33.655523 #1975406]  INFO -- : products/cloudscheduler: Generating types: ALL
I, [2021-06-15T01:17:33.655573 #1975406]  INFO -- : Generating Job
I, [2021-06-15T01:17:35.182233 #1975406]  INFO -- : products/firestore: Compiling provider config
I, [2021-06-15T01:17:35.300030 #1975406]  INFO -- : products/firestore: Generating types: ALL
I, [2021-06-15T01:17:35.300087 #1975406]  INFO -- : Generating Index
I, [2021-06-15T01:17:36.143708 #1975406]  INFO -- : Generating Document
I, [2021-06-15T01:17:37.860629 #1975406]  INFO -- : products/binaryauthorization: Compiling provider config
I, [2021-06-15T01:17:37.977974 #1975406]  INFO -- : products/binaryauthorization: Generating types: ALL
I, [2021-06-15T01:17:37.978025 #1975406]  INFO -- : Generating Attestor
I, [2021-06-15T01:17:39.338843 #1975406]  INFO -- : Generating Policy
I, [2021-06-15T01:17:39.810383 #1975406]  INFO -- : products/dialogflowcx: Compiling provider config
I, [2021-06-15T01:17:39.928764 #1975406]  INFO -- : products/dialogflowcx: Generating types: ALL
I, [2021-06-15T01:17:39.928813 #1975406]  INFO -- : Generating Agent
I, [2021-06-15T01:17:41.367309 #1975406]  INFO -- : products/monitoring: Compiling provider config
I, [2021-06-15T01:17:41.483605 #1975406]  INFO -- : products/monitoring: Generating types: ALL
I, [2021-06-15T01:17:41.483652 #1975406]  INFO -- : Generating AlertPolicy
I, [2021-06-15T01:17:42.567376 #1975406]  INFO -- : Generating Group
I, [2021-06-15T01:17:43.858366 #1975406]  INFO -- : Generating NotificationChannel
I, [2021-06-15T01:17:45.178946 #1975406]  INFO -- : Generating Service
I, [2021-06-15T01:17:46.472677 #1975406]  INFO -- : Generating Slo
I, [2021-06-15T01:17:48.088459 #1975406]  INFO -- : Generating UptimeCheckConfig
I, [2021-06-15T01:17:49.514054 #1975406]  INFO -- : Generating MetricDescriptor
I, [2021-06-15T01:17:50.886980 #1975406]  INFO -- : products/firebase does not have a 'ga' version, skipping
I, [2021-06-15T01:17:50.910743 #1975406]  INFO -- : products/servicedirectory does not have a 'ga' version, skipping
I, [2021-06-15T01:17:51.023105 #1975406]  INFO -- : products/dialogflow: Compiling provider config
I, [2021-06-15T01:17:51.139882 #1975406]  INFO -- : products/dialogflow: Generating types: ALL
I, [2021-06-15T01:17:51.139930 #1975406]  INFO -- : Generating Agent
I, [2021-06-15T01:17:52.007661 #1975406]  INFO -- : Generating Intent
I, [2021-06-15T01:17:52.897538 #1975406]  INFO -- : Generating EntityType
I, [2021-06-15T01:17:53.284024 #1975406]  INFO -- : Generating Fulfillment
I, [2021-06-15T01:17:53.753343 #1975406]  INFO -- : products/tpu: Compiling provider config
I, [2021-06-15T01:17:53.873211 #1975406]  INFO -- : products/tpu: Generating types: ALL
I, [2021-06-15T01:17:53.873259 #1975406]  INFO -- : Generating Node
I, [2021-06-15T01:17:55.549800 #1975406]  INFO -- : Copying common files for terraform
I, [2021-06-15T01:17:55.733715 #1975406]  INFO -- : Compiling common files for terraform

Modified

cd $(go env GOPATH)/src/github.com/hashicorp/terraform-provider-google
$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   google/container_operation.go
	modified:   website/docs/r/bigquery_table_iam.html.markdown
	modified:   website/docs/r/cloud_identity_group_membership.html.markdown
	modified:   website/docs/r/cloud_run_service.html.markdown
	modified:   website/docs/r/compute_address.html.markdown
	modified:   website/docs/r/compute_autoscaler.html.markdown
	modified:   website/docs/r/compute_backend_bucket.html.markdown
	modified:   website/docs/r/compute_backend_service.html.markdown
	modified:   website/docs/r/compute_disk.html.markdown
	modified:   website/docs/r/compute_forwarding_rule.html.markdown
	modified:   website/docs/r/compute_global_address.html.markdown
	modified:   website/docs/r/compute_global_forwarding_rule.html.markdown
	modified:   website/docs/r/compute_image_iam.html.markdown
	modified:   website/docs/r/compute_instance_iam.html.markdown
	modified:   website/docs/r/compute_region_autoscaler.html.markdown
	modified:   website/docs/r/compute_region_backend_service.html.markdown
	modified:   website/docs/r/compute_region_disk.html.markdown
	modified:   website/docs/r/compute_router.html.markdown
	modified:   website/docs/r/compute_subnetwork.html.markdown
	modified:   website/docs/r/compute_subnetwork_iam.html.markdown
	modified:   website/docs/r/compute_target_instance.html.markdown
	modified:   website/docs/r/compute_vpn_tunnel.html.markdown
	modified:   website/docs/r/dns_managed_zone.html.markdown
	modified:   website/docs/r/filestore_instance.html.markdown
	modified:   website/docs/r/healthcare_dicom_store.html.markdown
	modified:   website/docs/r/healthcare_fhir_store.html.markdown
	modified:   website/docs/r/healthcare_hl7_v2_store.html.markdown
	modified:   website/docs/r/iap_app_engine_service_iam.html.markdown
	modified:   website/docs/r/iap_app_engine_version_iam.html.markdown
	modified:   website/docs/r/iap_tunnel_iam.html.markdown
	modified:   website/docs/r/iap_tunnel_instance_iam.html.markdown
	modified:   website/docs/r/iap_web_backend_service_iam.html.markdown
	modified:   website/docs/r/iap_web_iam.html.markdown
	modified:   website/docs/r/iap_web_type_app_engine_iam.html.markdown
	modified:   website/docs/r/iap_web_type_compute_iam.html.markdown
	modified:   website/docs/r/redis_instance.html.markdown
	modified:   website/docs/r/storage_bucket_iam.html.markdown
	modified:   website/docs/r/vpc_access_connector.html.markdown

no changes added to commit (use "git add" and/or "git commit -a")

Test

$ make test
==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
go generate  ./...
go test  -timeout=30s $(go list ./...)
?   	github.com/hashicorp/terraform-provider-google	[no test files]
ok  	github.com/hashicorp/terraform-provider-google/google	22.402s
?   	github.com/hashicorp/terraform-provider-google/scripts/affectedtests	[no test files]
?   	github.com/hashicorp/terraform-provider-google/scripts/sidebar	[no test files]
?   	github.com/hashicorp/terraform-provider-google/version	[no test files]

Lint

$ make lint
==> Checking source code against linters...
$ echo $?
0

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 21 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 2 files changed, 21 insertions(+), 11 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192126"

@ScottSuarez ScottSuarez merged commit 47e1883 into GoogleCloudPlatform:master Jun 15, 2021
@ScottSuarez
Copy link
Contributor

lgtm

This was referenced Jun 15, 2021
Merged
Merged
@karlkfi karlkfi deleted the container-operation-project-override branch June 15, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottSuarez ScottSuarez ScottSuarez approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ContainerOperationWaiter doesn't support UserProjectOverride
3 participants
@karlkfi @modular-magician @ScottSuarez