-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change update verb for apigee_envgroup to patch #5047
change update verb for apigee_envgroup to patch #5047
Conversation
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM potentially - Is there a way to add a reasonable test for this? I know apigee resources can take a while to set up but maybe the basic test could be expanded to also do an update?
I totally agree and in normal circumstances I would be inclined to add them but with the volume of bugs and the ease of the fix in this method I am choosing to exclude in the essence of time. There are other things that call to my attention at the moment that make the timebox needed to add the test infra not worth it considering the needed functions are not already in place. I've tested locally and provided a debug log below. I hope thats sufficient.
|
I leave it to your discretion. I'm glad to hear you can verify the fix locally. |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateBasicExample|TestAccDialogflowCXEnvironment_dialogflowcxEnvironmentFullExample|TestAccDialogflowCXVersion_dialogflowcxVersionFullExample|TestAccDialogflowCXEnvironment_update|TestAccDialogflowCXVersion_update You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=199977 |
closes hashicorp/terraform-provider-google#9696
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)