Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete poll check #5096

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Aug 16, 2021

Fixes hashicorp/terraform-provider-google#9245

Delete is eventually consistent, so let's poll check the resource absence on delete

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

pubsub: added polling to `google_pubsub_schema` to deal with eventually consistent deletes

@google-cla google-cla bot added the cla: yes label Aug 16, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 42 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 42 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccPubsubSchema_pubsubSchemaBasicExample|TestAccPubsubTopic_pubsubTopicSchemaSettingsExample|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201357

@c2thorn c2thorn requested review from a team and melinath and removed request for a team August 16, 2021 19:59
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, I didn't know about this functionality! LGTM

@c2thorn c2thorn merged commit 482783f into GoogleCloudPlatform:master Aug 19, 2021
@c2thorn c2thorn deleted the pubsub_schema branch August 19, 2021 20:33
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flakey test: TestAccPubsubSchema_pubsubSchemaBasicExample
3 participants