-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow updates on google_service_attachment
#5157
allow updates on google_service_attachment
#5157
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 348 insertions(+), 9 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=203644 |
Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline Please fix these to complete your PR |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 355 insertions(+), 10 deletions(-)) |
/gcbru |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 355 insertions(+), 10 deletions(-)) |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 355 insertions(+), 10 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccApiGatewayApiConfig_apigatewayApiConfigFullExample|TestAccApiGatewayApi_apigatewayApiBasicExample|TestAccApiGatewayApi_apigatewayApiFullExample|TestAccApiGatewayGateway_apigatewayGatewayBasicExample|TestAccApiGatewayGateway_apigatewayGatewayFullExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryBasicExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryCmekExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryIamExample|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeBackendService_backendServiceTrafficDirectorRingHashExample|TestAccComputeBackendService_backendServiceTrafficDirectorRoundRobinExample|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeGlobalAddress_globalAddressPrivateServicesConnectExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeHealthCheck_healthCheckWithLoggingExample|TestAccComputeMachineImage_machineImageBasicExample|TestAccComputeMachineImage_computeMachineImageKmsExample|TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccComputeOrganizationSecurityPolicy_organizationSecurityPolicyBasicExample|TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleBasicExample|TestAccComputeRegionBackendService_regionBackendServiceCacheExample|TestAccComputeRegionBackendService_regionBackendServiceExternalExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttpLogsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeSubnetwork_subnetworkInternalL7lbExample|TestAccComputeTargetInstance_targetInstanceCustomNetworkExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagBasicExample|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagChildPoliciesExample|TestAccDataCatalogTaxonomy_dataCatalogTaxonomyBasicExample|TestAccDataFusionInstance_dataFusionInstanceBasicExample|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample|TestAccDNSManagedZone_dnsManagedZoneServiceDirectoryExample|TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccFirebaseProject_firebaseProjectBasicExample|TestAccFirebaseProjectLocation_firebaseProjectLocationBasicExample|TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample|TestAccHealthcareHl7V2Store_healthcareHl7V2StoreParserConfigExample|TestAccHealthcareHl7V2Store_healthcareHl7V2StoreUnschematizedExample|TestAccIAMBetaWorkloadIdentityPool_iamWorkloadIdentityPoolFullExample|TestAccIAMBetaWorkloadIdentityPool_iamWorkloadIdentityPoolBasicExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderAwsBasicExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderAwsFullExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcBasicExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcFullExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesPackagesExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesRecipesExample|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccServiceDirectoryNamespace_serviceDirectoryNamespaceBasicExample|TestAccServiceDirectoryEndpoint_serviceDirectoryEndpointBasicExample|TestAccSecurityScannerScanConfig_scanConfigBasicExample|TestAccServiceDirectoryService_serviceDirectoryServiceBasicExample|TestAccServiceUsageConsumerQuotaOverride_consumerQuotaOverrideExample|TestAccServiceUsageConsumerQuotaOverride_consumerQuotaOverrideZeroValueExample|TestAccServiceUsageConsumerQuotaOverride_regionConsumerQuotaOverrideExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=203850 |
Tests failed during RECORDING mode: TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleBasicExample|TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesPackagesExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesRecipesExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample Please fix these to complete your PR |
closes hashicorp/terraform-provider-google#9647
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)