Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta fields from the google provider #5262

Merged
merged 6 commits into from
Oct 26, 2021

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Sep 30, 2021

Part of hashicorp/terraform-provider-google#8696

We don't need to remove RIGM manager.DistributionPolicy.TargetShape as it has since GA'ed

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: removed the `update_policy.min_ready_sec` field from `google_compute_instance_group_manager`, `google_compute_region_instance_group_manager` in the GA provider
compute: removed the `enable_display` field from `google_compute_instance_template` in the GA provider
container: removed the `pod_security_policy_config` field from `google_container_cluster` in the GA provider
container: removed the `workload_identity_config.0.identity_namespace` field from `google_container_cluster`, use `workload_identity_config.0.workload_pool` instead
runtimeconfig: removed the Runtime Configurator service from the `google` (GA) provider including `google_runtimeconfig_config`, `google_runtimeconfig_variable`, `google_runtimeconfig_config_iam_policy`, `google_runtimeconfig_config_iam_binding`, `google_runtimeconfig_config_iam_member`, `data.google_runtimeconfig_config`. They are only available in the `google-beta` provider, as the underlying service is in beta.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 17 insertions(+), 38 deletions(-))
Terraform Beta: Diff ( 8 files changed, 7 insertions(+), 16 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+))

@rileykarson rileykarson force-pushed the goodbye-beta branch 2 times, most recently from db51579 to 205cb82 Compare October 5, 2021 19:09
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 14 files changed, 17 insertions(+), 479 deletions(-))
Terraform Beta: Diff ( 13 files changed, 20 insertions(+), 68 deletions(-))
TF Conversion: Diff ( 2 files changed, 1 insertion(+), 10 deletions(-))

@rileykarson rileykarson force-pushed the goodbye-beta branch 2 times, most recently from 3b78376 to 0173f7c Compare October 5, 2021 19:27
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 19 files changed, 27 insertions(+), 522 deletions(-))
Terraform Beta: Diff ( 18 files changed, 35 insertions(+), 66 deletions(-))
TF Conversion: Diff ( 3 files changed, 1 insertion(+), 35 deletions(-))

@rileykarson rileykarson force-pushed the goodbye-beta branch 2 times, most recently from 578aa6d to 9c724d3 Compare October 5, 2021 19:51
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 21 files changed, 25 insertions(+), 986 deletions(-))
Terraform Beta: Diff ( 16 files changed, 33 insertions(+), 64 deletions(-))
TF Conversion: Diff ( 3 files changed, 1 insertion(+), 35 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 24 files changed, 25 insertions(+), 1431 deletions(-))
Terraform Beta: Diff ( 18 files changed, 35 insertions(+), 66 deletions(-))
TF Conversion: Diff ( 3 files changed, 1 insertion(+), 35 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 24 files changed, 25 insertions(+), 1437 deletions(-))
Terraform Beta: Diff ( 18 files changed, 35 insertions(+), 66 deletions(-))
TF Conversion: Diff ( 3 files changed, 1 insertion(+), 35 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRuntimeConfigConfigIamPolicyGenerated|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionPerInstanceConfig_update You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=209187

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 26 files changed, 27 insertions(+), 1453 deletions(-))
Terraform Beta: Diff ( 18 files changed, 36 insertions(+), 67 deletions(-))
TF Conversion: Diff ( 3 files changed, 1 insertion(+), 35 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeForwardingRule_update|TestAccPubsubLiteReservation_pubsubLiteReservationBasicExample|TestAccPubsubLiteTopic_pubsubLiteTopicBasicExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=209581

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 29 files changed, 336 insertions(+), 1896 deletions(-))
Terraform Beta: Diff ( 21 files changed, 380 insertions(+), 560 deletions(-))
TF Conversion: Diff ( 3 files changed, 1 insertion(+), 35 deletions(-))
TF Validator: Diff ( 3 files changed, 2 insertions(+), 36 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 28 files changed, 33 insertions(+), 1614 deletions(-))
Terraform Beta: Diff ( 20 files changed, 42 insertions(+), 228 deletions(-))
TF Conversion: Diff ( 3 files changed, 1 insertion(+), 35 deletions(-))
TF Validator: Diff ( 3 files changed, 2 insertions(+), 36 deletions(-))

@rileykarson rileykarson requested a review from slevenick October 25, 2021 19:03
@@ -29,14 +29,14 @@ objects:
name: 'Config'
base_url: projects/{{project}}/configs
self_link: projects/{{project}}/configs/{{name}}
min_version: beta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need min_version if the only available version is beta?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the change a while ago- I think yes, because the example keyed off of it or something.

@@ -937,7 +937,6 @@ resource "google_compute_instance_group_manager" "igm-rolling-update-policy" {
minimal_action = "REPLACE"
max_surge_fixed = 2
max_unavailable_fixed = 2
min_ready_sec = 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the unless version tags around these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that in one place, and removed the rest- not much point in polluting the rest of the tests w/ guards when they aren't testing novel behaviour imo.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update|TestAccComposerEnvironment_ComposerV2|TestAccComputeBackendBucket_backendBucketFullExample|TestAccComputeBackendBucket_withCdnPolicy|TestAccDataprocCluster_withServiceAcc|TestAccProject_migrateParent|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=212547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants