-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove beta fields from the google
provider
#5262
Remove beta fields from the google
provider
#5262
Conversation
aba2184
to
3321c6a
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 8 files changed, 17 insertions(+), 38 deletions(-)) |
db51579
to
205cb82
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 14 files changed, 17 insertions(+), 479 deletions(-)) |
3b78376
to
0173f7c
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 19 files changed, 27 insertions(+), 522 deletions(-)) |
578aa6d
to
9c724d3
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 21 files changed, 25 insertions(+), 986 deletions(-)) |
9c724d3
to
66415cc
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 24 files changed, 25 insertions(+), 1431 deletions(-)) |
66415cc
to
dd77ac6
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 24 files changed, 25 insertions(+), 1437 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRuntimeConfigConfigIamPolicyGenerated|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionPerInstanceConfig_update You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=209187 |
dd77ac6
to
b3d9f17
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 26 files changed, 27 insertions(+), 1453 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeForwardingRule_update|TestAccPubsubLiteReservation_pubsubLiteReservationBasicExample|TestAccPubsubLiteTopic_pubsubLiteTopicBasicExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=209581 |
b3d9f17
to
3442d97
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 29 files changed, 336 insertions(+), 1896 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 28 files changed, 33 insertions(+), 1614 deletions(-)) |
@@ -29,14 +29,14 @@ objects: | |||
name: 'Config' | |||
base_url: projects/{{project}}/configs | |||
self_link: projects/{{project}}/configs/{{name}} | |||
min_version: beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need min_version
if the only available version is beta
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the change a while ago- I think yes, because the example keyed off of it or something.
@@ -937,7 +937,6 @@ resource "google_compute_instance_group_manager" "igm-rolling-update-policy" { | |||
minimal_action = "REPLACE" | |||
max_surge_fixed = 2 | |||
max_unavailable_fixed = 2 | |||
min_ready_sec = 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want the unless version tags around these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that in one place, and removed the rest- not much point in polluting the rest of the tests w/ guards when they aren't testing novel behaviour imo.
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update|TestAccComposerEnvironment_ComposerV2|TestAccComputeBackendBucket_backendBucketFullExample|TestAccComputeBackendBucket_withCdnPolicy|TestAccDataprocCluster_withServiceAcc|TestAccProject_migrateParent|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=212547 |
Part of hashicorp/terraform-provider-google#8696
We don't need to remove RIGM manager.DistributionPolicy.TargetShape as it has since GA'ed
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)