fixed labels for array value

[edwardmedia]

Fixes hashicorp/terraform-provider-google#10201

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

billingbudget: fixed unable to provide `labels` on `google_billing_budget`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 30 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 30 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccBillingBudget_billingBudgetCurrencycode You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=209115

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 29 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 29 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 29 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 30 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccBillingBudget_billingBudgetCurrencycode You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=209144

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 29 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 29 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=209152

[ScottSuarez]

Sort of confused on what is going on here, could you explain the current behavior? Aren't labels always returned as objects?

[ScottSuarez]

I don't understand why the current implementation doesn't work?

[edwardmedia]

This is a special case. You may see the difference about what this api takes @ScottSuarez

label1 : ["aaa"]. <---- this case

label1 : "aaa". <-----normal case

[rileykarson]

Leaving review to @ScottSuarez - feel free to assign me if Scott needs to hand off or after Scott's approved if you want addtl review, I don't like to have two reviewers acting at once.

[ScottSuarez]

asking Riley to take over here. I'll stay on the ticket to observe comments. Even with context provided this is fairly confusing behavior on the api's behalf.

[rileykarson]

What an unusual type for the API to expect, especially given it's restricted anyways. From the API docs: Currently, multiple entries or multiple values per entry are not allowed.

[rileykarson]

I swear the approve button just moved on me...