Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_compute_router_status data source #5307

Merged
merged 7 commits into from
Nov 17, 2021

Conversation

tbh1
Copy link
Contributor

@tbh1 tbh1 commented Oct 11, 2021

Add a new Terraform data source, google_compute_router_status, to expose details such as routes learned via BGP peers.

Fixes hashicorp/terraform-provider-google#9662

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute:  New `google_compute_router_status` data source

Add a new Terraform data source, google_compute_router_status, to
expose details such as routes learned via BGP peers.
@google-cla
Copy link

google-cla bot commented Oct 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 11, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

@tbh1
Copy link
Contributor Author

tbh1 commented Oct 11, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 11, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 6 files changed, 356 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 5 files changed, 355 insertions(+))

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 6 files changed, 356 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeRouterStatus|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210442

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccDataSourceComputeRouterStatus Please fix these to complete your PR

@ScottSuarez ScottSuarez self-requested a review October 13, 2021 23:49
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 6 files changed, 356 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 5 files changed, 355 insertions(+))

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 5 files changed, 355 insertions(+))

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 6 files changed, 356 insertions(+), 1 deletion(-))

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 5 files changed, 355 insertions(+))

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 5 files changed, 355 insertions(+))

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 6 files changed, 356 insertions(+), 1 deletion(-))

@ScottSuarez
Copy link
Contributor

manually rerunning failed test
https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=212728

thanks for your patience

@ScottSuarez
Copy link
Contributor

=== RUN   TestAccDataSourceComputeRouterStatus
=== PAUSE TestAccDataSourceComputeRouterStatus
=== CONT  TestAccDataSourceComputeRouterStatus
    provider_test.go:278: Step 1/1 error: Check failed: Check 7/7 error: data.google_compute_router_status.router1: Attribute 'best_routes.0.next_hop_vpn_tunnel' expected "https://www.googleapis.com/compute/v1/projects/****/regions/us-central1/vpnTunnels/ha-vpn-tunnel1-lk4q09kn2g", got "https://www.googleapis.com/compute/beta/****/regions/us-central1/vpnTunnels/ha-vpn-tunnel1-lk4q09kn2g"
--- FAIL: TestAccDataSourceComputeRouterStatus (209.11s)

@ScottSuarez
Copy link
Contributor

still looks like the same issue on the test. Sorry this took so long

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 11 files changed, 359 insertions(+), 3 deletions(-))

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 15 files changed, 365 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 13 files changed, 358 insertions(+), 6 deletions(-))

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 5 files changed, 355 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeRouterStatus|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccBillingBudget_billingBudgetCurrencycode|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudFunctionsFunction_basic|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeFirewallPolicyRule_update|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccComputeOrganizationSecurityPolicy_organizationSecurityPolicyUpdateExample|TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleUpdateExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccContainerAnalysisOccurrence_multipleSignatures|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_ephemeralStorageConfig|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlDatabaseInstance_withPrivateNetwork|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=215443

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 355 insertions(+))
Terraform Beta: Diff ( 5 files changed, 355 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccPubsubTopicIamBindingGenerated|TestAccPubsubTopicIamMemberGenerated|TestAccPubsubTopicIamPolicyGenerated|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudRunService_secretVolume|TestAccCloudRunService_secretEnvironmentVariable|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccPubsubTopic_pubsubTopicBasicExample|TestAccSqlUser_postgresIAM|TestAccTPUNode_tpuNodeBUpdateTensorFlowVersion You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=217053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Cloud Router Status
3 participants